Skip to content

Fix opacity not applying to text fragment backgrounds #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Brayozin wants to merge 2 commits into
base: master
Choose a base branch
from
+4 −3
Open

Fix opacity not applying to text fragment backgrounds #48

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1f581c3
Fix opacity not applying to text fragment backgrounds
Brayozin Apr 3, 2026
739cb9d
Update text fragment background drawing to disable transparency
Brayozin Apr 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lib/TerminalDisplay.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -760,6 +760,7 @@ QColor TerminalDisplay::keyboardCursorColor() const
void TerminalDisplay::setOpacity(qreal opacity)
{
_opacity = qBound(static_cast<qreal>(0), opacity, static_cast<qreal>(1));
update();
}

void TerminalDisplay::setBackgroundImage(const QString& backgroundImage)
Expand Down
6 changes: 3 additions & 3 deletions lib/TerminalDisplay.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,9 +134,6 @@ class KONSOLEPRIVATE_EXPORT TerminalDisplay : public QQuickPaintedItem
*/
uint randomSeed() const;

/** Sets the opacity of the terminal display. */
void setOpacity(qreal opacity);

/**
* This enum describes the location where the scroll bar is positioned in the display widget.
*/
Expand Down Expand Up @@ -596,6 +593,9 @@ public slots:
*/
void setBackgroundColor(const QColor& color);

/** Sets the opacity of the terminal display. */
void setOpacity(qreal opacity);

/**
* Sets the text of the display to the specified color.
* @see setColorTable(), setBackgroundColor()
Expand Down