Fix for when GH_TOKEN is not set#42
Open
berquist wants to merge 1 commit intoSyntaf:masterfrom
berquist:gh-token-fail
Open
Fix for when GH_TOKEN is not set#42berquist wants to merge 1 commit intoSyntaf:masterfrom berquist:gh-token-fail
berquist wants to merge 1 commit intoSyntaf:masterfrom
berquist:gh-token-fail
Conversation
Accidentally introduced in 10e0f25
Codecov Report
@@ Coverage Diff @@
## master #42 +/- ##
=======================================
Coverage 81.88% 81.88%
=======================================
Files 5 5
Lines 138 138
=======================================
Hits 113 113
Misses 25 25
Continue to review full report at Codecov.
|
Owner
|
Thanks for the typo fix, but why are you removing the default value of |
Author
|
The empty string does not properly trigger this line, which leads to falling through to the message "Deploy triggered for non-master branch 'master': skipping deploy" and having the deploy return as successful. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The exception was never being thrown because
GH_TOKENwas neverNone.Accidentally introduced in 10e0f25.