Refactor music lock system: allow DJs to bypass lock

[SyntaxNyah]

Summary

Refactored the music lock system to clarify its purpose and expand who can bypass it. The /musiclock and /musicunlock commands now explicitly allow DJs (in addition to moderators and CMs) to change music when locked, and the permission requirement to use these commands has been lowered from CM-only to DJ-level.

Key Changes

• Updated music lock behavior: DJs can now change music even when the area is locked, matching the documented intent. Added DJ permission check to both cmdPlay() and CanChangeMusic() methods.

• Lowered command permissions: Changed /musiclock and /musicunlock from requiring CM permission to requiring only DJ permission, making the feature more accessible to area DJs.

• Clarified messaging:

  • Replaced "frozen" terminology with "locked" throughout user-facing messages for consistency
  • Updated command descriptions to explicitly state "only moderators and DJs can change it"
  • Changed area announcements to use em-dashes and clearer language (e.g., "🔒 has locked the music — only moderators and DJs can change it")

• Updated documentation: Revised code comments in areas.go to reflect that DJs are now exempt from the music lock restriction.

• Removed unrelated change: Removed the warning message sent to users when they are permanently ignored (in cmdIgnore), as this was outside the scope of the music lock refactor.

Implementation Details

The music lock check now includes an additional condition:

if client.Area().MusicFrozen() && !permissions.IsModerator(client.Perms()) && !client.HasCMPermission() && !permissions.HasPermission(client.Perms(), permissions.PermissionField["DJ"])

This ensures that moderators, CMs, and DJs all retain the ability to change music when an area is locked, while regular players cannot.

https://claude.ai/code/session_012Weg2Teoh5VB19DtQkYZmA