README と UI を CTF Solver Workbench 中心に再構成#18
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5a44320a7d
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| actionLabel: "String Transform を開く", | ||
| to: "/ctf", |
There was a problem hiding this comment.
When users choose the new “String Transform” action, this still routes to /ctf; checked src/App.tsx and that path renders CtfPage, whose UI is only a static CTF reference list with no input or transform controls. In the CTF-focused UI this makes the primary quick-start path land on a page that cannot perform the advertised workflow, so users trying to transform challenge strings are blocked or misled unless the route is changed to an actual transformer or the label is kept as a reference page.
Useful? React with 👍 / 👎.
|
確認しましたが、この PR は現状マージしません。 理由:
対応案:
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1dd817b3f1
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| export const HomePage: React.FC = () => { | ||
| return ( | ||
| <div> | ||
| <h2 style={{ marginBottom: "20px", fontSize: "20px" }}> | ||
| Network Information | ||
| </h2> | ||
|
|
||
| {loading && <LoadingSpinner message="Fetching network info..." />} | ||
| {error && <ErrorMessage message={error} />} | ||
|
|
||
| {networkInfo && ( | ||
| <div style={{ display: "grid", gridTemplateColumns: "1fr 1fr", gap: "16px" }}> | ||
| <div style={cardStyle}> | ||
| <div style={labelStyle}>IP Address</div> | ||
| <div style={valueStyle}>{networkInfo.ip_address}</div> | ||
| </div> | ||
| <div style={cardStyle}> | ||
| <div style={labelStyle}>Broadcast Address</div> | ||
| <div style={valueStyle}>{networkInfo.broadcast_address}</div> | ||
| </div> | ||
| <div style={cardStyle}> | ||
| <div style={labelStyle}>Interface</div> | ||
| <div style={valueStyle}>{networkInfo.interface_name}</div> | ||
| </div> | ||
| <div style={cardStyle}> | ||
| <div style={labelStyle}>Subnet Mask</div> | ||
| <div style={valueStyle}>{networkInfo.subnet_mask}</div> | ||
| </div> | ||
| {networkInfo.gateway && ( | ||
| <div style={cardStyle}> | ||
| <div style={labelStyle}>Gateway</div> | ||
| <div style={valueStyle}>{networkInfo.gateway}</div> | ||
| <div style={pageStyle}> |
There was a problem hiding this comment.
When users need the Network Information feature, this replacement of the root page leaves it unreachable: the sidebar now sends / to the CTF workspace, and a repo-wide check of rg "useNetworkInfo" src shows the hook is no longer invoked by any page. Since the README still lists network interface information as an available Advanced / Network Lab feature and the Tauri command remains registered, this regression removes the only UI path that displayed IP, broadcast, interface, subnet, and gateway details unless a new route/nav entry is added or the old panel is preserved elsewhere.
Useful? React with 👍 / 👎.
1 participant
Motivation
Advanced / Network Labセクションへ移し、主フローの可視性を高めるため。Description
README.mdの冒頭説明を「CTF Solver Workbench」「Local-first CTF Assistant」系の表現へ差し替え、機能一覧でCTF Workspace/String Transform/Artifact Analyzer/Flag Candidate Detection/Writeup Exportを主機能として先に並べ、ネットワーク機能をAdvanced / Network Lab / Legacy・Experimentalに分離しました（README.mdを編集）。Advanced / Network Labグループへ移動するようにsrc/components/Layout/Sidebar.tsxを書き換え、補助ラベル表示とグループ見出し用の CSS をsrc/components/Layout/Sidebar.module.cssに追加しました。src/pages/HomePage.tsxを差し替えました。README.md,src/components/Layout/Sidebar.tsx,src/components/Layout/Sidebar.module.css,src/pages/HomePage.tsx）。Testing
npm run buildを実行してプロダクションビルドを生成し成功しました（vite buildによるビルド完了）。npm run lintを実行して ESLint のチェックを通過しました。Codex Task