Fix overflow in floating point multiplication#33
Open
iglesias wants to merge 1 commit intoTA-Lib:mainfrom
Open
Fix overflow in floating point multiplication#33iglesias wants to merge 1 commit intoTA-Lib:mainfrom
iglesias wants to merge 1 commit intoTA-Lib:mainfrom
Conversation
Member
|
Thanks. The proposed change is in the right direction, but the fix has to be applied differently though. So leaving this open for now to keep track. Two issues with the proposed change: (2) The same source code has to remain compatible with Java, C, C++ and C++ managed (and may be Rust soon!). So the fix must either work with all these setup (verified with ta_regtest) OR make your change specific to the language you are fixing with the pre-processor Example: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.