feat: use TALXIS.Platform.Metadata.Packaging library for solution pack/unpack#43
Open
metjuperry wants to merge 1 commit into
Open
feat: use TALXIS.Platform.Metadata.Packaging library for solution pack/unpack#43metjuperry wants to merge 1 commit into
metjuperry wants to merge 1 commit into
Conversation
…k/unpack On .NET 10+ (MSBuildRuntimeType=Core), InvokeSolutionPackager now uses the TALXIS.Platform.Metadata.Packaging library directly instead of shelling out to PAC CLI. This eliminates the PAC CLI runtime dependency and provides faster, more reliable solution packing/unpacking. On .NET Framework (net472), the PAC CLI fallback is retained since the packaging library targets net10.0. Also upgrades Tasks TFM from net472;net6.0 to net472;net10.0 and updates the .targets assembly path accordingly. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactors
InvokeSolutionPackagerMSBuild task to use the newTALXIS.Platform.Metadata.Packaginglibrary for solution packing/unpacking, eliminating the PAC CLI runtime dependency on .NET 10+.How it works
net10.0(dotnet build): UsesTALXIS.Platform.Metadata.Packaging.SolutionPackagerServicedirectly via the library — no PAC CLI needednet472(Visual Studio / .NET Framework MSBuild): Falls back to the existing PAC CLI shell-out approachThis is achieved using
#if NET10_0_OR_GREATERconditional compilation.Changes
TALXIS.DevKit.Build.Dataverse.Tasks.csproj:net472;net6.0→net472;net10.0TALXIS.Platform.Metadata.Packagingpackage reference (conditioned on non-net472)InvokeSolutionPackager.cs:NET10_0_OR_GREATER: calls the packaging library directly withSolutionPackagerOptions.targets: Updated assembly path fromnet6.0\\→net10.0\\Dependencies
TALXIS.Platform.Metadata.PackagingNuGet package to be published (see platform-metadata PR #48)Benefits
tools-cli(PR #80)