Skip to content

Annadhm A3#43

Open
annadhm wants to merge 7 commits into
mainfrom
annadhm-A3
Open

Annadhm A3#43
annadhm wants to merge 7 commits into
mainfrom
annadhm-A3

Conversation

@annadhm

@annadhm annadhm commented Apr 22, 2026

Copy link
Copy Markdown
Collaborator

Please review :)

@AnesIms

AnesIms commented Apr 22, 2026

Copy link
Copy Markdown
Collaborator

The code worked in my test and the output matches the assignment requirements.
I especially like that the code is clearly structured and easy to follow. I also really liked the “Algorithm Steps” section in the README, because it makes the overall program flow very easy to understand.

One small improvement could be to make the README examples a bit more concrete by showing one or two actual expected outputs directly there as well.

One question or edge case to consider: what should happen if -d is used on an input file that does not actually contain a diagonal block?

++ Top-tier error message game!! :)

@annadhm

annadhm commented Apr 23, 2026

Copy link
Copy Markdown
Collaborator Author

Thank you Anes,
I got Inspired by your error messages from the last time :)

I reviewed my code and README after your suggestions. The -d flag handling was a good point. I didn't thought about it because my code didn't throw an error at this point.

Thank you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants