Skip to content

Assignment 3#45

Open
AnesIms wants to merge 1 commit into
mainfrom
AnesIms-A3
Open

Assignment 3#45
AnesIms wants to merge 1 commit into
mainfrom
AnesIms-A3

Conversation

@AnesIms

@AnesIms AnesIms commented Apr 22, 2026

Copy link
Copy Markdown
Collaborator

Please review :)

@juwei95

juwei95 commented Apr 22, 2026

Copy link
Copy Markdown
Collaborator

✅ Your code works and matches the specified output for all the test cases.
The input validation and error handling are very thorough.

🚀 Your hot loops are tight and fast.
I measured your program's runtime with my test script. Here are the results:

Test case Runtime [ms]
Manhattan-testHV1.in 21
Manhattan-testHV2.in 20
Manhattan-testHV3.in 22
Manhattan-testHVD1.in 19
Manhattan-testHVD2.in 548

💡 The way you handle the -d flag at the very top level makes your code clear and easy to reason about, but it also causes some duplication. For example one could argue that two distinct versions of traceback are not strictly necessary.

🤔 One thing to consider is that you could actually process HVD files just fine without the -d flag by treating them as HV files, rather than throw an error. However, I can see why you chose to make the error explicit.

😆 I really liked your hidden fun fact.

Overall a very clean solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants