Hannah task A3#47
Conversation
|
Hey Hannah, One case you could consider is the matrix dimension validation. Your code assumes that the matrices are consistent and derive the grid size from the first row only. There is no check for consistency between the different input sections (NS/WE/DIAG) or an irregular row length. As a result, wrong input formats are processed leading to incorrect results without warning or error. Overall all I really like your documenting style! Your code is good to follow through all the comments you made. Great Job!🥳 |
|
Hey Anna, thank you for your feedback! I now added a validate_matrix function to make sure that the matrices are consistent :) |
Please review :)