Skip to content

Hannah task A3#47

Open
HannahSophie08 wants to merge 2 commits into
mainfrom
HannahSophie08-A3
Open

Hannah task A3#47
HannahSophie08 wants to merge 2 commits into
mainfrom
HannahSophie08-A3

Conversation

@HannahSophie08

Copy link
Copy Markdown
Collaborator

Please review :)

@annadhm

annadhm commented Apr 23, 2026

Copy link
Copy Markdown
Collaborator

Hey Hannah,
Well done, your code produces the correct outputs ! 👑 I really like that you thought about the -d flag handling in HV cases. One could consider that the -d flag could be ignored that the programm simply produces the "normal" output an does not crash. But that is a design choice I would say, and your way to do definetely not wrong :)

One case you could consider is the matrix dimension validation. Your code assumes that the matrices are consistent and derive the grid size from the first row only. There is no check for consistency between the different input sections (NS/WE/DIAG) or an irregular row length. As a result, wrong input formats are processed leading to incorrect results without warning or error.

Overall all I really like your documenting style! Your code is good to follow through all the comments you made.

Great Job!🥳

@HannahSophie08

Copy link
Copy Markdown
Collaborator Author

Hey Anna, thank you for your feedback! I now added a validate_matrix function to make sure that the matrices are consistent :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants