Skip to content

julia-gro A3 (script and README) - manhattan problem#48

Open
julia-gro wants to merge 3 commits into
mainfrom
julia-gro-A3
Open

julia-gro A3 (script and README) - manhattan problem#48
julia-gro wants to merge 3 commits into
mainfrom
julia-gro-A3

Conversation

@julia-gro

Copy link
Copy Markdown
Collaborator

ready for review :)

@julia-gro julia-gro changed the title assignment 3 (script and README) - manhattan problem julia-gro At 3 (script and README) - manhattan problem Apr 22, 2026
@julia-gro julia-gro changed the title julia-gro At 3 (script and README) - manhattan problem julia-gro A3 (script and README) - manhattan problem Apr 22, 2026
@HannahSophie08

Copy link
Copy Markdown
Collaborator

Your code produces the expected output, great work! I really like how clearly structured and straightforward your implementation is. Your README documentation is thorough and gives all the necessary information, making it easy to understand and use your program.
One thing you could consider is making the command-line input independent of argument order. At the moment, placing the input file before the flags results in an error. Using something like argparse could help make this more flexible.
In the assignment it states that the tourist should prefer south in the case of a tie, whereas your implementation currently prefers diagonal moves. You could consider changing this, however your current approach still works correctly, so this is optional :)
Overall you did a great job, especially in making your code and README clear, well-structured and user-friendly! Great job! 🥇

@julia-gro

Copy link
Copy Markdown
Collaborator Author

Thank you Hannah for your feedback, I have fixed the issues that you've pointed out :)

I also added another flag '-m' after reviewing the assignment of anna-gst. She had it incorporated, and I thought it was a really good idea. Additionally I added an alternate input-file containing a possible edge case: two consecutive matrices happen to have the same row length.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants