Skip to content

Juwei95 A4#49

Open
juwei95 wants to merge 3 commits into
mainfrom
juwei95-A4
Open

Juwei95 A4#49
juwei95 wants to merge 3 commits into
mainfrom
juwei95-A4

Conversation

@juwei95

@juwei95 juwei95 commented May 1, 2026

Copy link
Copy Markdown
Collaborator

Ready for review :)

@eweindorfer

Copy link
Copy Markdown
Collaborator

First off, big fan of your coding style! Clear naming conventions and minimal lines of code needed to produce the desired output. Your README is also very helpful.

The output itself is good too! Only special characters, eg. 'ä' are not correctly displayed for me (on Win10). Adding some utf specification to the file parser could probably fix that.

A more crucial detail is how the random seed is handled. In your code the default value is set to 0, which unfortunately means that the same command (with no seed set by the user) will always use '0' as a seed and therefore return the same output. This could be avoided by choosing None as a default value.

Overall, great job! :)
The text generation works as intended with no hick-ups on any of the files that I tested .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants