Juwei95 A4#49
Conversation
|
First off, big fan of your coding style! Clear naming conventions and minimal lines of code needed to produce the desired output. Your README is also very helpful. The output itself is good too! Only special characters, eg. 'ä' are not correctly displayed for me (on Win10). Adding some utf specification to the file parser could probably fix that. A more crucial detail is how the random seed is handled. In your code the default value is set to 0, which unfortunately means that the same command (with no seed set by the user) will always use '0' as a seed and therefore return the same output. This could be avoided by choosing None as a default value. Overall, great job! :) |
Ready for review :)