Skip to content

Script, Readme and additional Test input for A4#51

Open
annadhm wants to merge 1 commit into
mainfrom
annadhm-A4
Open

Script, Readme and additional Test input for A4#51
annadhm wants to merge 1 commit into
mainfrom
annadhm-A4

Conversation

@annadhm

@annadhm annadhm commented May 4, 2026

Copy link
Copy Markdown
Collaborator

Please Review :)

@HannahSophie08

Copy link
Copy Markdown
Collaborator

Hey Anna, your code successfully generates text using a Markov model. I especially like your thorough documentation and the clear structure of your code. You also did a great job considering edge cases, including the possibility of infinite loops. I like how you handled this by introducing a maximum output length.
As a possible improvement, you could give the user the option to define this limit via a command-line option, which would make this behavior more transparent and give the users more control.
Other than that I didn't find anything to improve! Great job :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants