eweindorfer A4#52
Conversation
|
The code seems to work well and supports the required options like One small thing to reconsider is the removal of punctuation in character-based mode. The assignment explicitly mentions that punctuation may remain in word mode, but it does not require removing punctuation in character mode. So keeping the original characters might be closer to the specification. One possible improvement could be memory efficiency. The current dictionary approach is simple and easy to understand, but it could become quite memory-heavy for larger texts. One edge case that could be considered is what happens if the chosen order Overall, a very nice implementation! :) |
Ready for review!