Skip to content

Kralina123 A4#53

Open
kralina123 wants to merge 3 commits into
mainfrom
kralina123-A4
Open

Kralina123 A4#53
kralina123 wants to merge 3 commits into
mainfrom
kralina123-A4

Conversation

@kralina123

Copy link
Copy Markdown
Collaborator

No description provided.

@Ez3k4

Ez3k4 commented May 6, 2026

Copy link
Copy Markdown
Collaborator

Hey Alina,
Overall your code looks really clean and is kept very simple which makes it super readable. Also your comments help a lot to understand what is going on. Using bisect makes the code look a lot cleaner, maybe something i should have done too haha!
The only thing that could be a potential improve is to create an own function to read and tokenize the file, but that is a subjective preference.
I tested the code and it worked perfectly.
Really good job :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants