You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hey I reviewed your code and it works great!
The output is correct and I like all the additional flags you added as well as the error messages for flags being used incorrectly. I especially like what you did with the '.join(list). I haven't even considered the time complexity of small operations like concatenation of strings but you're absolutely right that str += str will take much longer for larger text. I definitely learned something new :)
I only have a small suggestion which is mainly for the readability of your code. It would be good if your args had individual names besides the flag name -o, -l etc.
When you wrote the error messages for the incorrectly used flags you referenced each flag with args.o or args.l. While it was easy to keep in mind what they represent, it can get confusing when you have to do this for many more args. I would recommend using some extra naming such as '-o', '--markov_order', then you can call it with args.markov_order. It's a small addition but it could help in the long run.
You really did great! And thanks for the new info!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ready for review. Thx :)