You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Code works and produces nice outputs for the test files used.
Your code is very simple and easy to follow, the output is also nicely formatted with the textwrapper. The way you split your functions separates the two cases, words and characters very nicely and makes for a clean script that is easy to read. I am a bit torn on it though since the functions are fairly repetitive and could be adapted to handle both cases I think, but thats a matter of taste.
I like your approach of allowing the user to specify the max length and it would be even nicer if the output was printed in real time so that the user could see they are stuck in a cycle. It's funny reading your warning about running indefinitely while hearing your laptop fight for its life haha.
Last but not least, <3 the LotR text file! Well done!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ready for review