Merged
Conversation
📝 WalkthroughWalkthrough체리 레벨 시스템을 1–4에서 0–4로 확장해 Changes
Sequence Diagram(s)(해당 변경은 내부 데이터 모델과 계산 로직 변경에 한정되며 다중 컴포넌트 제어 흐름 변경이 아니므로 시퀀스 다이어그램을 생략합니다.) Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
src/main/java/com/sopt/cherrish/domain/challenge/core/domain/model/CherryLevel.java (1)
34-38: Javadoc의 유효 범위(1-4) 업데이트 필요.현재 주석이 1-4로 남아 있어 레벨 0 추가와 불일치합니다.
✏️ 제안 수정
- * `@param` level 체리 레벨 (1-4) + * `@param` level 체리 레벨 (0-4)
🤖 Fix all issues with AI agents
In
`@src/main/java/com/sopt/cherrish/domain/challenge/core/domain/model/CherryLevel.java`:
- Around line 21-25: Update the Javadoc for the CherryLevel.fromLevel(Integer)
method to reflect the new enum range including LEVEL_0: change any references
that say "1-4" to "0-4" and adjust the `@param` description to indicate valid
level values are 0 through 4 (or handle null as currently documented). Locate
the fromLevel method and its Javadoc in the CherryLevel enum class and correct
the textual range so it accurately documents LEVEL_0 through LEVEL_4.
src/main/java/com/sopt/cherrish/domain/challenge/core/domain/model/CherryLevel.java
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Related issue 🛠
✏️ Work Description ✏️
calculateCherryLevel(): completedCount == 0이면 레벨 0 반환getProgressToNextLevel(): completedCount == 0이면 0.0 반환getRemainingRoutinesToNextLevel(): 레벨 0, 1 모두 레벨 2(25%)까지 남은 개수 반환📸 Screenshot 📸
😅 Uncompleted Tasks 😅
📢 To Reviewers 📢