fix: persist classroom to server for cross-device access#218
Open
reddingit wants to merge 1 commit intoTHU-MAIC:mainfrom
Open
fix: persist classroom to server for cross-device access#218reddingit wants to merge 1 commit intoTHU-MAIC:mainfrom
reddingit wants to merge 1 commit intoTHU-MAIC:mainfrom
Conversation
Previously, classrooms were only stored in browser IndexedDB, making them inaccessible from other devices on the same network. This fix: - Calls POST /api/classroom when first scene is generated to persist initial data - Updates server storage again when all scenes complete generation - Allows other devices to fetch classroom data via API instead of relying solely on local storage Fixes 404 errors when accessing classrooms from different devices in LAN. Editor: vscode
3b6bd50 to
0a2f5da
Compare
|
@reddingit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes 404 errors when accessing classrooms from different devices on the same network. Previously, classrooms were only stored in browser IndexedDB, making them inaccessible from other devices. This change persists classroom data to server-side storage, enabling cross-device access via the API.
Related Issues
N/A (new fix)
Changes
app/generation-preview/page.tsx: Added server-side persistence call after first scene generation, before navigation to classroom pageapp/classroom/[id]/page.tsx: Added server-side update call inonCompletecallback when all scenes finish generationdata/classrooms/{id}.jsonon the server filesystemType of Change
Verification
Steps to reproduce / test
pnpm devhttp://<Device-A-IP>:3000/classroom/<id>What you personally verified
/api/classroomendpoint)Evidence
pnpm check && pnpm lint && npx tsc --noEmit)Checklist