fix: preserve text-only rows in multimodal datasets - #2277
Open
VanyMo wants to merge 1 commit into
Open
Conversation
VanyMo
marked this pull request as ready for review
August 16, 2026 17:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When
multimodal_keysis configured for a mixed dataset, a text-only row can have no multimodal values. In that case_build_messagesbuilds the regular expression()from an empty placeholder mapping.Python treats that as an empty capturing group, so
re.split("()", "hello")splits the text into individual characters. The row is then passed to the chat template and processor as many one-character text blocks instead of its original string content.This is separate from #2237, which preserves sample order while filtering mixed text and multimodal rows.
Change
Return the conversation unchanged when the current row contains no multimodal values. Rows with actual multimodal placeholders continue through the existing expansion path.
Add CPU regressions for both the text-only case and the existing image-placeholder behavior.
Validation
.venv/bin/python -m pytest tests/test_filter_long_prompt.py -q— 7 passedruff check slime/utils/data.py tests/test_filter_long_prompt.py— passedblack --check slime/utils/data.py tests/test_filter_long_prompt.py— passedgit diff --check— passed