Skip to content

My sqldml#252

Open
sushantkumbhar wants to merge 2 commits into
TIBCOSoftware:masterfrom
sushantkumbhar:mySQLDML
Open

My sqldml#252
sushantkumbhar wants to merge 2 commits into
TIBCOSoftware:masterfrom
sushantkumbhar:mySQLDML

Conversation

@sushantkumbhar
Copy link
Copy Markdown

What kind of change does this PR introduce? (check one with "x")

[x] Bugfix
[] Feature- This activity provides your flogo application the ability to fire a select, update, Delete and insert queries to MYSQL database.
[x] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[x] Other... Please describe:

Fixes: #

What is the current behavior?
As per Current behaviour, In Flogo only MySQL Select query activity is available.
What is the new behavior?
This feature will help to fire select, update, Delete and insert queries to MYSQL database using single code.

@sushantkumbhar
Copy link
Copy Markdown
Author

Waiting for the reviews

@retgits
Copy link
Copy Markdown

retgits commented Jul 25, 2018

Hi! Thanks for the PR, but could you make sure all the references are correct (for example the "ref" field points to the GitHub repository of another person). Also, could you make sure the return type is a JSON object ("any" type) instead of a string? That would make the mapping in other activities a lot easier

@sushantkumbhar
Copy link
Copy Markdown
Author

Hi Sir, thank you for the feedback. I have done the changes please check.

@sushantkumbhar
Copy link
Copy Markdown
Author

please accept the pull request.

@mellistibco
Copy link
Copy Markdown
Contributor

Hi @sushantkumbhar sorry! I'll take a look and merge.

@sushantkumbhar
Copy link
Copy Markdown
Author

Hi, Can you please update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants