Skip to content

Allow the KnowledgeBaseImpl to store the KIs URI for all active KIs. #872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bnouwt merged 1 commit into from
Jun 29, 2026
Merged

Allow the KnowledgeBaseImpl to store the KIs URI for all active KIs. #872

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
86 changes: 82 additions & 4 deletions smart-connector/src/main/java/eu/knowledge/engine/smartconnector/util/KnowledgeBaseImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,17 @@
import eu.knowledge.engine.smartconnector.impl.SmartConnectorBuilder;
import eu.knowledge.engine.smartconnector.impl.Util;

/**
* This class helps creating knowledge bases easily for testing purposes.
* Multiple {@code KnowledgeBaseImpl} instances can be collected in a
* {@link KnowledgeNetwork} and managed and checked together.
*
* Note that the {@link KnowledgeBaseImpl#register(AskKnowledgeInteraction)}
* methods do not directly register the KI with the corresponding Smart
* Connector. This only happens when the {@link KnowledgeBaseImpl#syncKIs()}
* methods is called. The same holds for the
* {@link #unregister(AnswerKnowledgeInteraction)} methods.
*/
public class KnowledgeBaseImpl implements KnowledgeBase {

private static final Logger LOG = LoggerFactory.getLogger(KnowledgeBaseImpl.class);
Expand All @@ -62,6 +73,11 @@ public class KnowledgeBaseImpl implements KnowledgeBase {
private final Set<PostKnowledgeInteraction> currentPostKIs;
private final Map<ReactKnowledgeInteraction, ReactHandler> currentReactKIs;

/**
* Keep track of KI URIs of registered KIs.
*/
private final Map<KnowledgeInteraction, URI> currentKiToUri;

private final Set<AskKnowledgeInteraction> unregisteredAskKIs;
private final Set<AnswerKnowledgeInteraction> unregisteredAnswerKIs;
private final Set<PostKnowledgeInteraction> unregisteredPostKIs;
Expand Down Expand Up @@ -100,6 +116,8 @@ public KnowledgeBaseImpl(String anId, String aName, String aDescription) {
this.currentPostKIs = ConcurrentHashMap.newKeySet();
this.currentReactKIs = new ConcurrentHashMap<>();

this.currentKiToUri = new ConcurrentHashMap<>();

this.unregisteredAskKIs = ConcurrentHashMap.newKeySet();
this.unregisteredAnswerKIs = ConcurrentHashMap.newKeySet();
this.unregisteredPostKIs = ConcurrentHashMap.newKeySet();
Expand Down Expand Up @@ -186,6 +204,7 @@ protected SmartConnector getSC() {

public CompletableFuture<Void> stop() {
CompletableFuture<Void> future = this.sc.stop();
this.sc = null;
// remove all KIs
this.unregisteredAskKIs.clear();
this.unregisteredAnswerKIs.clear();
Expand All @@ -194,40 +213,82 @@ public CompletableFuture<Void> stop() {
return future;
}

/**
* Stores the given KI for registration when {@link #syncKIs()} is called.
*
* @param anAskKI
*/
public void register(AskKnowledgeInteraction anAskKI) {
this.registeredAskKIs.add(anAskKI);
}

/**
* Stores the given KI for unregistration when {@link #syncKIs()} is called.
*
* @param anAskKI
*/
public void unregister(AskKnowledgeInteraction anAskKI) {
boolean removed = this.currentAskKIs.remove(anAskKI);
assert removed;
this.unregisteredAskKIs.add(anAskKI);
}

/**
* Stores the given KI for registration when {@link #syncKIs()} is called.
*
* @param anAnswerKI
* @param aAnswerHandler
*/
public void register(AnswerKnowledgeInteraction anAnswerKI, AnswerHandler aAnswerHandler) {
this.registeredAnswerKIs.put(anAnswerKI, aAnswerHandler);
}

/**
* Stores the given KI for unregistration when {@link #syncKIs()} is called.
*
* @param anAnswerKI
*/
public void unregister(AnswerKnowledgeInteraction anAnswerKI) {
assert this.currentAnswerKIs.containsKey(anAnswerKI);
this.currentAnswerKIs.remove(anAnswerKI);
this.unregisteredAnswerKIs.add(anAnswerKI);
}

/**
* Stores the given KI for registration when {@link #syncKIs()} is called.
*
* @param aPostKI
*/
public void register(PostKnowledgeInteraction aPostKI) {
this.registeredPostKIs.add(aPostKI);
}

/**
* Stores the given KI for unregistration when {@link #syncKIs()} is called.
*
* @param aPostKI
*/
public void unregister(PostKnowledgeInteraction aPostKI) {
boolean removed = this.currentPostKIs.remove(aPostKI);
assert removed;
this.unregisteredPostKIs.add(aPostKI);
}

/**
* Stores the given KI for registration when {@link #syncKIs()} is called.
*
* @param anReactKI
* @param aReactHandler
*/
public void register(ReactKnowledgeInteraction anReactKI, ReactHandler aReactHandler) {
this.registeredReactKIs.put(anReactKI, aReactHandler);
}

/**
* Stores the given KI for unregistration when {@link #syncKIs()} is called.
*
* @param anReactKI
*/
public void unregister(ReactKnowledgeInteraction anReactKI) {
assert this.currentReactKIs.containsKey(anReactKI);
this.currentReactKIs.remove(anReactKI);
Expand Down Expand Up @@ -282,6 +343,15 @@ public Map<ReactKnowledgeInteraction, ReactHandler> getReactKnowledgeInteraction
return all;
}

public URI getKnowledgeInteractionURI(KnowledgeInteraction aKI) {
return this.currentKiToUri.get(aKI);
}

public KnowledgeInteraction getKnowledgeInteraction(URI anURI) {
return this.currentKiToUri.entrySet().stream().filter(entry -> entry.getValue().equals(anURI)).findFirst().get()
.getKey();
}

public boolean isUpToDate(AskKnowledgeInteraction askKnowledgeInteraction,
Set<KnowledgeBaseImpl> someKnowledgeBases) {

Expand Down Expand Up @@ -505,8 +575,9 @@ public synchronized void syncKIs() {

for (var ki : this.registeredAskKIs) {
try {
this.getSC().register(ki);
URI anURI = this.getSC().register(ki);
this.currentAskKIs.add(ki);
this.currentKiToUri.put(ki, anURI);
} catch (IllegalArgumentException iae) {
LOG.error("Registering KI {} should succeed.", ki, iae);
}
Expand All @@ -515,8 +586,9 @@ public synchronized void syncKIs() {

for (var entry : this.registeredAnswerKIs.entrySet()) {
try {
this.getSC().register(entry.getKey(), entry.getValue());
URI anURI = this.getSC().register(entry.getKey(), entry.getValue());
this.currentAnswerKIs.put(entry.getKey(), entry.getValue());
this.currentKiToUri.put(entry.getKey(), anURI);
} catch (IllegalArgumentException iae) {
LOG.error("Registering KI {} should succeed.", entry.getKey(), iae);
}
Expand All @@ -525,8 +597,9 @@ public synchronized void syncKIs() {

for (var ki : this.registeredPostKIs) {
try {
this.getSC().register(ki);
URI anURI = this.getSC().register(ki);
this.currentPostKIs.add(ki);
this.currentKiToUri.put(ki, anURI);
} catch (IllegalArgumentException iae) {
LOG.error("Registering KI {} should succeed.", ki, iae);
}
Expand All @@ -535,8 +608,9 @@ public synchronized void syncKIs() {

for (var entry : this.registeredReactKIs.entrySet()) {
try {
this.getSC().register(entry.getKey(), entry.getValue());
URI anURI = this.getSC().register(entry.getKey(), entry.getValue());
this.currentReactKIs.put(entry.getKey(), entry.getValue());
this.currentKiToUri.put(entry.getKey(), anURI);
} catch (IllegalArgumentException iae) {
LOG.error("Registering KI {} should succeed.", entry.getKey(), iae);
}
Expand All @@ -546,24 +620,28 @@ public synchronized void syncKIs() {
for (var ki : this.unregisteredAskKIs) {
this.getSC().unregister(ki);
this.currentAskKIs.remove(ki);
this.currentKiToUri.remove(ki);
}
this.unregisteredAskKIs.clear();

for (var ki : this.unregisteredAnswerKIs) {
this.getSC().unregister(ki);
this.currentAnswerKIs.remove(ki);
this.currentKiToUri.remove(ki);
}
this.unregisteredAnswerKIs.clear();

for (var ki : this.unregisteredPostKIs) {
this.getSC().unregister(ki);
this.currentPostKIs.remove(ki);
this.currentKiToUri.remove(ki);
}
this.unregisteredPostKIs.clear();

for (var ki : this.unregisteredReactKIs) {
this.getSC().unregister(ki);
this.currentReactKIs.remove(ki);
this.currentKiToUri.remove(ki);
}
this.unregisteredReactKIs.clear();

Expand Down
Loading