Conversation
Instead of always showing all 3 theme icon buttons (light/dark/xanga) next to the hamburger, the header now shows only the active theme's icon. Clicking it opens a small dropdown tray listing the 3 theme options; selecting one applies the theme, closes the tray, and updates the trigger icon to match. Closes on outside click or Escape. Co-authored-by: Thomas Bohn <bohn.tl@gmail.com>
Previously, the icon shown in the header to bring back a hidden Xanga sidebar reused the same 3-line hamburger glyph as the new mobile nav toggle, which was confusing (two differently-purposed 'hamburger' buttons). It also always restored to the right side regardless of where the sidebar was before it was hidden. - Add a dedicated RestoreSidebarIcon (panel outline + highlighted side + chevron) that's visually distinct from both the hamburger and the theme icons, and points toward the side it will restore to. - Track lastVisibleSide (persisted to localStorage) so restoring brings the sidebar back on whichever side it was on before being hidden, instead of always defaulting to the right. - Give the button a bordered/tinted treatment so it reads as a deliberate recovery action rather than a routine toggle. - The restore action stays in the header itself (not folded into the theme tray), since it's a page-layout fix-up rather than a color scheme choice. Co-authored-by: Thomas Bohn <bohn.tl@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sandbox validated and ready for production
This PR was opened automatically after
sandboxwas validated bythis workflow run.
npm run build): passed9a19df046b783aaecfe3fbce30f68872aed0e934Commits included in this promotion
Review checklist
This PR requires manual human review and must be merged by a person.
This automation will never merge it.