Conversation
…ring selector html[data-theme="xanga"] body a[class*="bg-accent"] was meant to fix contrast for links with a literal, resting bg-accent background, but [class*=...] does substring matching against the whole class string - so it also matched inactive mobile-nav links whose only accent-flavored class was the hover-prefixed "hover:bg-accent-orange", forcing dark --on-accent text onto them even at rest (on top of their actual dark navy background), making Home/Blog/Contact/Hub/Links/V2ME/Learning/Projects unreadable in the mobile menu. Excludes any element whose class also contains "hover:bg-accent" from this always-on rule, matching the same guard already used for the analogous hover-only overrides a few lines down. Co-authored-by: Thomas Bohn <bohn.tl@gmail.com>
…range .gradient-btn was always orange and .gradient-btn-blue was always blue, so the homepage showed one blue CTA (Request VIP Access) next to one orange CTA (Get in touch) regardless of theme, which read as an arbitrary/inconsistent color choice. Introduces --btn-primary-from/-to/-text/-shadow-rgb tokens that resolve per theme: blue in light mode (matching light's already-dark, high contrast --accent), orange in dark and Xanga modes (since dark's --accent is a lighter blue that needs a dark-text workaround, and Xanga's --accent already *is* the orange). .gradient-btn now uses these tokens, and both homepage CTAs share the single .gradient-btn class, so they always match each other and swap color together based on theme. Removes the now-unused --accent-blue/-hover/on-accent-blue tokens and .gradient-btn-blue, which existed solely to force one button blue regardless of theme. Co-authored-by: Thomas Bohn <bohn.tl@gmail.com>
…modifier bug Nudges hardcoded/fixed colors across the site toward the theme system: - Profile photo accent bar (page.tsx, about/page.tsx) used raw light-mode hex values (#c85200/#fc7d0b/#1170aa) instead of the accent-orange-hover/ accent-orange/accent tokens they were meant to represent, so it stayed frozen at light-mode colors in dark/Xanga. - ProjectArtifact type badges (artifact/deliverable/phase/example) used hardcoded Tableau-palette hex values (comments literally named them 'Tableau Dark Blue' etc.) instead of the equivalent semantic tokens, for the same reason. - Blog listing's Medium icon hover used hover:text-black, an actual contrast failure (near-invisible) on dark/Xanga's near-black background. - 'Read on Medium' buttons (blog/[slug]/page.tsx) and the LinkedIn contact tile used literal bg-black/text-white and LinkedIn's brand blue regardless of theme, inconsistent with how this site already represents Medium (orange, on the homepage Medium card) and email (theme accent, on the Email tile) - aligned them to the same convention. Also fixes two structural bugs uncovered while making these changes: - tailwind.config.ts colors were plain strings, which Tailwind cannot decompose into RGB channels at build time - so every opacity-modifier utility built on them (bg-accent/10, border-accent/40, etc.) was silently generating no CSS at all, leaving several existing elements (the header's sidebar-restore button, decorative photo-frame borders, the contact page's VIP callout box, five v2me tag pills, plus the new artifact badges) with fully transparent backgrounds/borders instead of the intended tinted ones. Wrapped every color in color-mix() with the <alpha-value> placeholder so Tailwind can generate correct opacity variants while still resolving the actual color from the CSS variable at runtime. - html[data-theme="xanga"] body [class*="text-accent"] used the same loose substring-match pattern already fixed for bg-accent: it also matched text-accent-hover and text-accent-orange (both contain "text-accent"), forcing them all to var(--accent) instead of their own shade - which made the new artifact badges (and anything else using text-accent-hover/text-accent-orange in Xanga) collapse to a single color. Added :not() guards plus dedicated rules for the hover/orange variants. Co-authored-by: Thomas Bohn <bohn.tl@gmail.com>
Author
|
Sandbox re-validated at |
…stency-fixes-abac # Conflicts: # tailwind.config.ts Co-authored-by: Thomas Bohn <bohn.tl@gmail.com>
Author
|
Sandbox re-validated at |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sandbox validated and ready for production
This PR was opened automatically after
sandboxwas validated bythis workflow run.
npm run build): passedb2f6dc947e38d244f3897b4bec055fe8a69afb22Commits included in this promotion
Review checklist
This PR requires manual human review and must be merged by a person.
This automation will never merge it.