Remove tom_alertstreams_base; Add dependency groups for stream clients#49
Open
phycodurus wants to merge 4 commits intodevfrom
Open
Remove tom_alertstreams_base; Add dependency groups for stream clients#49phycodurus wants to merge 4 commits intodevfrom
phycodurus wants to merge 4 commits intodevfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR
tom_alertstreams_base,manage.py: this was a leftover Django project that isn't appropriate for this stand-alone Django app.pyproject.toml, creates optional dependency groups for each kafka client library: not all TOM developers will need to install all the differenct kafka clients. This allow them to be selective about which client libraries that they install.@griffin-h: I'm including you on the review to keep you in the loop because when this is released, you may need to update your
pyproject.tomlfiles in your TOMs to specify which kafka client dependencies you want to install. Please let me know if you have any questions.Closes #41