15 tom eso api client library enhancements#23
Merged
phycodurus merged 39 commits intodevfrom Jan 8, 2026
Merged
Conversation
Bumps [flake8](https://github.com/pycqa/flake8) from 7.0.0 to 7.3.0. - [Commits](PyCQA/flake8@7.0.0...7.3.0) --- updated-dependencies: - dependency-name: flake8 dependency-version: 7.3.0 dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Bump flake8 from 7.0.0 to 7.3.0
Bumps [tomtoolkit](https://github.com/TOMToolkit/tom_base) from 2.25.0 to 2.25.1. - [Release notes](https://github.com/TOMToolkit/tom_base/releases) - [Commits](TOMToolkit/tom_base@2.25.0...2.25.1) --- updated-dependencies: - dependency-name: tomtoolkit dependency-version: 2.25.1 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
…abot/pip/tomtoolkit-2.25.1
Bump tomtoolkit from 2.25.0 to 2.25.1
This was
linked to
issues
Jul 30, 2025
Closed
Also, get the ESO P2 credentials from the ESOProfile.
The installation has been simplified by using the integration points and the ESOProfile to store credentials.
jchate6
requested changes
Aug 15, 2025
Contributor
jchate6
left a comment
jchate6
left a comment
There was a problem hiding this comment.
I would also add an explanation for the default username/profile situation to the profile card itself. Make the explanation conditional on if the default is currently set, so users with actual credentials don't see it.
jchate6
reviewed
Aug 21, 2025
Contributor
jchate6
left a comment
jchate6
left a comment
There was a problem hiding this comment.
This still isn't working for me the way it used to.
Is there something else I need to do to get these to work?
Also, refactor _configure_credentials to simplify and accurate reflect how/where credentials were obtained
the link has moved to the top of the page
jchate6
approved these changes
Jan 6, 2026
Contributor
jchate6
left a comment
jchate6
left a comment
There was a problem hiding this comment.
I've done some changes (mostly infrastructure), feel free to look at them before merging.
Contributor
|
Actually, we'll need to bump the TOMtoolkit version to the latest release when that's out before deploying this. |
github-project-automation
bot
moved this from Needs Review
to Merged (to dev)
in TOM Toolkit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors the ESO facility integration to use user-specific credentials from the
ESOProfile.ESOProfileESOAPIclass is refactored to require explicitenvironment,username, andpasswordparameters, removing the singleton pattern and settings dependency.NotImplementedErrorfor clarity.Also, merged into this branch:
The facility is still in prototype stage and we may even want to rethink the ESO P2 Tool iframe in lieu of opening up the ESO P2 Tool in another browser TAB/window, but we should get some customer feedback @talister and @carrholt first and foremost.