Open
Conversation
In this case, make the Fink broker appear in TOMToolkit's list of DataServices, when tom_fink is INSTALLED. TOMToolkit will look for certain methods in the AppConfig of a TOM's INSTALLED_APPS to ask the App how to integrate it into the TOM. This makes apps more self contained and reduces app-specific configuration data in settings.py.
This is part of the "DataServices refactor" of the Fink broker interface.
7 tasks
- minimal form changes: remove GenericQueryForm.common_layout
(it is replaced by layout in the BaseQueryForm)
- the FinkBroker has been removed
- FinkBroker.to_generic_alert and FinkBroker.to_target functionality
condensed into create_target_from_query
- FinkerBroker.fetch_alerts is now FinkDataService._fetch_alerts
and FinkDataServic.query_service just calls _fetch_alerts.
- minimal form changes: remove GenericQueryForm.common_layout
(it is replaced by layout in the BaseQueryForm)
- the FinkBroker has been removed
- FinkBroker.to_generic_alert and FinkBroker.to_target functionality
condensed into create_target_from_query
- FinkerBroker.fetch_alerts is now FinkDataService._fetch_alerts
and FinkDataServic.query_service just calls _fetch_alerts.
condense query results in to structure suitable for presenting in the selectable "create target" table.
The target table row dictionary was updated to be appropriate for one-target-one-row. These changes follow from that and use the appropriate dict keys to get the data to create the target.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
FinkDataServiceclass; deprecatesFinkBrokerMy tests are passing with
poetry run python tom_fink/tests/run_tests.pyand a local, but un alteredtom_base(dev).