fix(annotations): snapshot dueItems to prevent index drift in learning session#3
Merged
Merged
Conversation
…g session When rating cards in LearningModal, reviewAnnotation() updates the card's due date. dueItems is a useMemo that re-filters by current time, so rated cards disappear from the array — shifting remaining indices and causing skipped or wrong cards. Fix: snapshot dueItems into a sessionItems state when the learning panel opens, and use sessionItems everywhere inside the session. Clear on close. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When rating cards in LearningModal,
reviewAnnotation()updates the card's due date. SincedueItemsis auseMemothat re-filters by current time, rated cards disappear from the array immediately — shifting remaining indices and causing skipped or wrong cards.Fix
Snapshot
dueItemsinto asessionItemsstate when the learning panel opens, and usesessionItemseverywhere inside the session. Clear on close.Changes
src/components/layout/right-panel/annotations-tab.tsx— 16 additions, 4 deletions🤖 Generated with Claude Code