This repository was archived by the owner on May 4, 2021. It is now read-only.
Cleanup page indexer request class#9
Open
markusguenther wants to merge 3 commits intoTYPO3-extensions:masterfrom
Open
Cleanup page indexer request class#9markusguenther wants to merge 3 commits intoTYPO3-extensions:masterfrom
markusguenther wants to merge 3 commits intoTYPO3-extensions:masterfrom
Conversation
markusguenther
commented
Mar 5, 2015
markusguenther
commented
- adjusting some php docs
- remove an unused variable $pageId in the getHeader method. It was also duplicated because itemId will be equal to the pageId in the page indexer
- Prevent warnings while indexing pages. The pages will be logged with errors so why should i see the warning in the scheduler?
Contributor
There was a problem hiding this comment.
Please don't use the @ silencer
Author
There was a problem hiding this comment.
But in this case you will get warnings in the backend and this is also not so nice ... you will see the error later in the backend module or devlog.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.