add option to disable tag/category releated search#112
Open
schugabe wants to merge 1 commit intoTYPO3GmbH:masterfrom
Open
add option to disable tag/category releated search#112schugabe wants to merge 1 commit intoTYPO3GmbH:masterfrom
schugabe wants to merge 1 commit intoTYPO3GmbH:masterfrom
Conversation
If you set the tag multiplier to 0 it currently still searches posts with the same tags. Since this is called multiplier I'd expect it to ignore the tags if it is set to zero.
benjaminkott
requested changes
Mar 9, 2020
Member
benjaminkott
left a comment
benjaminkott
left a comment
There was a problem hiding this comment.
Hey, please see: https://github.com/TYPO3GmbH/blog/blob/master/Classes/Domain/Repository/PostRepository.php#L356-L358
The conditions should not have any effect, not forced, but the constants configuration does not allow negative values to be used as a multiplier. If the value is set to 0, is set to 0 anyways.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you set the tag multiplier to 0 it currently still searches posts with the same tags. Since this is called multiplier I'd expect it to ignore the tags if it is set to zero.