Skip to content

fix: inspector border overlap and laggy toggle#230

Merged
datlechin merged 1 commit intomainfrom
fix/inspector-border-and-lag
Mar 9, 2026
Merged

fix: inspector border overlap and laggy toggle#230
datlechin merged 1 commit intomainfrom
fix/inspector-border-and-lag

Conversation

@datlechin
Copy link
Copy Markdown
Collaborator

Summary

  • bug: Inspector border overlaps the header #228: Remove .toolbarBackground(.hidden) for default connection colors so the system toolbar background covers the NSSplitViewController divider, preventing it from bleeding into the toolbar area.
  • bug: Inspector opening is very laggy #229: Defer isPresented.didSet side effects (UserDefaults write + NotificationCenter post) off the animation frame via DispatchQueue.main.async, eliminating the lag on toggle.

Test plan

  • Connect to a database with default (no) connection color — verify inspector divider does not extend into the toolbar
  • Connect with a colored connection — verify toolbar tint still works
  • Toggle inspector (Cmd+I) — verify smooth native animation matching the left sidebar
  • Select a row with auto-show inspector enabled — verify inspector opens smoothly
  • Open 2+ native tabs — verify inspector state syncs across tabs

@chatgpt-codex-connector
Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@datlechin datlechin merged commit ebd61b2 into main Mar 9, 2026
2 checks passed
@datlechin datlechin deleted the fix/inspector-border-and-lag branch March 9, 2026 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant