-
-
Notifications
You must be signed in to change notification settings - Fork 117
feat: add per-connection safe mode levels #250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
8ce0f94
feat: add per-connection safe mode levels replacing isReadOnly boolean
datlechin 2d285b9
test: add safe mode level tests for enum, guard, storage, and save paths
datlechin 1740c7a
fix: address code review feedback for safe mode levels
datlechin 027f254
docs: add safe mode levels documentation
datlechin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
118 changes: 118 additions & 0 deletions
118
TablePro/Core/Services/Infrastructure/SafeModeGuard.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,118 @@ | ||
| // | ||
| // SafeModeGuard.swift | ||
| // TablePro | ||
| // | ||
|
|
||
| import AppKit | ||
| import LocalAuthentication | ||
| import os | ||
|
|
||
| @MainActor | ||
| internal final class SafeModeGuard { | ||
| private static let logger = Logger(subsystem: "com.TablePro", category: "SafeModeGuard") | ||
|
|
||
| internal enum Permission { | ||
| case allowed | ||
| case blocked(String) | ||
| } | ||
|
|
||
| internal static func checkPermission( | ||
| level: SafeModeLevel, | ||
| isWriteOperation: Bool, | ||
| sql: String, | ||
| operationDescription: String, | ||
| window: NSWindow?, | ||
| databaseType: DatabaseType? = nil | ||
| ) async -> Permission { | ||
| let effectiveIsWrite: Bool | ||
| if let dbType = databaseType, dbType == .mongodb || dbType == .redis { | ||
| effectiveIsWrite = true | ||
| } else { | ||
| effectiveIsWrite = isWriteOperation | ||
| } | ||
|
|
||
| switch level { | ||
| case .silent: | ||
| return .allowed | ||
|
|
||
| case .readOnly: | ||
| if effectiveIsWrite { | ||
| return .blocked(String(localized: "Cannot execute write queries: connection is read-only")) | ||
| } | ||
| return .allowed | ||
|
|
||
| case .alert: | ||
| if effectiveIsWrite { | ||
| guard await showConfirmationAlert(sql: sql, operationDescription: operationDescription, window: window) else { | ||
| return .blocked(String(localized: "Operation cancelled by user")) | ||
| } | ||
| } | ||
| return .allowed | ||
|
|
||
| case .alertFull: | ||
| guard await showConfirmationAlert(sql: sql, operationDescription: operationDescription, window: window) else { | ||
| return .blocked(String(localized: "Operation cancelled by user")) | ||
| } | ||
| return .allowed | ||
|
|
||
| case .safeMode: | ||
| if effectiveIsWrite { | ||
| guard await showConfirmationAlert(sql: sql, operationDescription: operationDescription, window: window) else { | ||
| return .blocked(String(localized: "Operation cancelled by user")) | ||
| } | ||
| guard await authenticateUser() else { | ||
| return .blocked(String(localized: "Authentication required to execute write operations")) | ||
| } | ||
| } | ||
| return .allowed | ||
|
|
||
| case .safeModeFull: | ||
| guard await showConfirmationAlert(sql: sql, operationDescription: operationDescription, window: window) else { | ||
| return .blocked(String(localized: "Operation cancelled by user")) | ||
| } | ||
| guard await authenticateUser() else { | ||
| return .blocked(String(localized: "Authentication required to execute operations")) | ||
| } | ||
| return .allowed | ||
| } | ||
| } | ||
|
|
||
| private static func showConfirmationAlert( | ||
| sql: String, | ||
| operationDescription: String, | ||
| window: NSWindow? | ||
| ) async -> Bool { | ||
| let trimmed = sql.trimmingCharacters(in: .whitespacesAndNewlines) | ||
| let preview: String | ||
| if (trimmed as NSString).length > 200 { | ||
| preview = String(trimmed.prefix(200)) + "..." | ||
| } else { | ||
| preview = trimmed | ||
| } | ||
|
|
||
| return await AlertHelper.confirmDestructive( | ||
| title: operationDescription, | ||
| message: String(localized: "Are you sure you want to execute this query?\n\n\(preview)"), | ||
| confirmButton: String(localized: "Execute"), | ||
| cancelButton: String(localized: "Cancel"), | ||
| window: window | ||
| ) | ||
| } | ||
|
|
||
| private static func authenticateUser() async -> Bool { | ||
| await Task.detached { | ||
| let context = LAContext() | ||
| do { | ||
| return try await context.evaluatePolicy( | ||
| .deviceOwnerAuthentication, | ||
| localizedReason: String(localized: "Authenticate to execute database operations") | ||
| ) | ||
| } catch { | ||
| await MainActor.run { | ||
| logger.warning("Biometric authentication failed: \(error.localizedDescription)") | ||
| } | ||
| return false | ||
| } | ||
| }.value | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.