fix: replace .inspector() with custom panel to fix jittery animation#253
fix: replace .inspector() with custom panel to fix jittery animation#253
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Caution Review failedPull request was closed or merged during review 📝 WalkthroughWalkthroughThe right sidebar is restructured from an inspector-based approach to a discrete, animated pane within the NavigationSplitView. Panel width persistence via UserDefaults is added, along with a new interactive PanelResizeHandle component for drag-to-resize functionality. Frame constraints are adjusted to use flexible widths with explicit animation binding. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Comment |
…animation The .inspector() modifier uses an internal NSSplitViewController whose constraint-based animation becomes expensive at tight window widths. Replace with a lightweight HStack + transition panel that includes a drag-to-resize handle and persists the user's preferred width. Closes #243
Summary
.inspector()modifier with a customHStack+.transition(.move(edge: .trailing))panel for the right sidebar.inspector()modifier uses an internalNSSplitViewControllerwhose constraint-based animation becomes expensive at tight window widths, causing visible jitter/lagCloses #243
Test plan
Summary by CodeRabbit
New Features
Improvements