Conversation
|
All contributors have signed the CLA ✍️ ✅ |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughAdded Turkish ("tr") as a new language option: enum case and display name in app settings, Turkish region added to Xcode project knownRegions, and documentation/changelog updated to list "Türkçe" in Settings > General. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Comment Tip Migrating from UI to YAML configuration.Use the |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@docs/customization/settings.mdx`:
- Line 71: Add the missing Turkish language row to the Vietnamese language table
in docs/vi/customization/settings.mdx: locate the existing language table (the
row pattern like "| **English** | English |" or the surrounding table block) and
insert a new row matching the English file entry using the Vietnamese label: "|
**Türkçe** | Tiếng Thổ Nhĩ Kỳ |".
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 8ff2155c-0b8d-4283-ac26-5cac7bc20478
📒 Files selected for processing (5)
CHANGELOG.mdTablePro.xcodeproj/project.pbxprojTablePro/Models/Settings/AppSettings.swiftTablePro/Resources/Localizable.xcstringsdocs/customization/settings.mdx
|
I have read the CLA Document and I hereby sign the CLA. |
|
Hi @sineld, thank you for the contribution. Could you please address the above reviews, I'll merge the PR after reviews was resolved. |
|
@datlechin done. |
Add Turkish language support
Summary
Adds Turkish (Türkçe) as an app language. Users can select it in Settings > General > Language. The UI is localized with Turkish strings where provided; the rest fall back to English.
Changes
App language option
AppLanguageinTablePro/Models/Settings/AppSettings.swift: new caseturkish = "tr"with display name "Türkçe".TablePro.xcodeproj/project.pbxproj:tradded toknownRegions.String catalog
TablePro/Resources/Localizable.xcstrings: Turkish (tr) localizations added for all entries. ~780 strings have explicit Turkish translations; the rest keep the source (English) as fallback. Format strings (e.g.%@,%lld) keep placeholders and only the surrounding text is translated where applicable.Docs
docs/customization/settings.mdx: Turkish added to the Language table.CHANGELOG.md:[Unreleased] updated with Turkish language and translation script.Testing
Summary by CodeRabbit
New Features
Documentation