Skip to content

added Turkish language#350

Merged
datlechin merged 2 commits intoTableProApp:mainfrom
sineld:main
Mar 17, 2026
Merged

added Turkish language#350
datlechin merged 2 commits intoTableProApp:mainfrom
sineld:main

Conversation

@sineld
Copy link
Copy Markdown
Contributor

@sineld sineld commented Mar 17, 2026

Add Turkish language support

Summary

Adds Turkish (Türkçe) as an app language. Users can select it in Settings > General > Language. The UI is localized with Turkish strings where provided; the rest fall back to English.

Changes

  • App language option

    • AppLanguage in TablePro/Models/Settings/AppSettings.swift: new case turkish = "tr" with display name "Türkçe".
    • TablePro.xcodeproj/project.pbxproj: tr added to knownRegions.
  • String catalog

    • TablePro/Resources/Localizable.xcstrings: Turkish (tr) localizations added for all entries. ~780 strings have explicit Turkish translations; the rest keep the source (English) as fallback. Format strings (e.g. %@, %lld) keep placeholders and only the surrounding text is translated where applicable.
  • Docs

    • docs/customization/settings.mdx: Turkish added to the Language table.
    • CHANGELOG.md: [Unreleased] updated with Turkish language and translation script.
  • Testing

    • Choose Türkçe in Settings > General > Language and restart the app; UI should show Turkish where translated (e.g. "Lisansınızın süresi doldu" for "Your license has expired", "Sıfırla Doldur" for "Zero Fill").
    • Other languages (System, English, Vietnamese, 简体中文) unchanged.

Summary by CodeRabbit

  • New Features

    • Added Turkish language support (Türkçe) now available in application settings
  • Documentation

    • Updated documentation to include information about the new Turkish language option

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 17, 2026

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 17, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 24e5e793-1860-40f2-997f-418715dac2dd

📥 Commits

Reviewing files that changed from the base of the PR and between abb8528 and c057694.

📒 Files selected for processing (1)
  • docs/vi/customization/settings.mdx

📝 Walkthrough

Walkthrough

Added Turkish ("tr") as a new language option: enum case and display name in app settings, Turkish region added to Xcode project knownRegions, and documentation/changelog updated to list "Türkçe" in Settings > General.

Changes

Cohort / File(s) Summary
Language enum
TablePro/Models/Settings/AppSettings.swift
Added turkish = "tr" to AppLanguage and displayName mapping returning "Türkçe".
Xcode project
TablePro.xcodeproj/project.pbxproj
Added "tr" to knownRegions in the PBXProject section.
Docs & changelog
CHANGELOG.md, docs/customization/settings.mdx, docs/vi/customization/settings.mdx
Added Turkish ("Türkçe") to language lists and descriptions; changelog notes updated accordingly.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰🌿 I hopped in code and found a clue,
A tiny "tr" to join the crew,
"Türkçe" now sings within the list,
A nibble, a nibble—nothing missed,
Hooray for languages bold and new!

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'added Turkish language' accurately summarizes the main change in the pull request, which adds Turkish language support throughout the application.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
📝 Coding Plan
  • Generate coding plan for human review comments

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

Migrating from UI to YAML configuration.

Use the @coderabbitai configuration command in a PR comment to get a dump of all your UI settings in YAML format. You can then edit this YAML file and upload it to the root of your repository to configure CodeRabbit programmatically.

Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@docs/customization/settings.mdx`:
- Line 71: Add the missing Turkish language row to the Vietnamese language table
in docs/vi/customization/settings.mdx: locate the existing language table (the
row pattern like "| **English** | English |" or the surrounding table block) and
insert a new row matching the English file entry using the Vietnamese label: "|
**Türkçe** | Tiếng Thổ Nhĩ Kỳ |".

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 8ff2155c-0b8d-4283-ac26-5cac7bc20478

📥 Commits

Reviewing files that changed from the base of the PR and between 8662bad and abb8528.

📒 Files selected for processing (5)
  • CHANGELOG.md
  • TablePro.xcodeproj/project.pbxproj
  • TablePro/Models/Settings/AppSettings.swift
  • TablePro/Resources/Localizable.xcstrings
  • docs/customization/settings.mdx

@sineld
Copy link
Copy Markdown
Contributor Author

sineld commented Mar 17, 2026

I have read the CLA Document and I hereby sign the CLA.

github-actions bot added a commit that referenced this pull request Mar 17, 2026
@datlechin
Copy link
Copy Markdown
Collaborator

Hi @sineld, thank you for the contribution. Could you please address the above reviews, I'll merge the PR after reviews was resolved.

@sineld
Copy link
Copy Markdown
Contributor Author

sineld commented Mar 17, 2026

@datlechin done.

@datlechin datlechin merged commit f550c15 into TableProApp:main Mar 17, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants