feat(sqlserver): flip driver manifest to editing-ready (#149)

[saurabh500]

[Phase 2] Flip driver manifest to editing-ready (closes Phase 2)

Closes #149. Final Phase 2 PR — once #215 (insert) and #222 (composite UPDATE/DELETE) merge into feat/sql-server, this one flips the capability bits so the UI actually exposes those editing surfaces.

What changes

Backend — src-tauri/src/drivers/sqlserver/mod.rs

field	before	after
version	"0.1.0"	"0.2.0"
description	"Microsoft SQL Server (read-only preview)"	"Microsoft SQL Server"
capabilities.manage_tables	false	true
capabilities.readonly	true	false
capabilities.alter_column	false	false (Phase 3)
capabilities.create_foreign_keys	false	false (Phase 3)

Module doc comment updated to describe Phase 2 scope.

manifest_has_phase1_capabilities test renamed to manifest_has_phase2_capabilities, assertions inverted, and added explicit pins that alter_column / create_foreign_keys stay off (Phase 3).

Frontend — src/hooks/useDrivers.ts

Mirrors the Rust manifest in FALLBACK_DRIVERS (version, description, manage_tables, readonly). This is the offline fallback shown before the Tauri command returns; the real manifest comes from the driver itself, but keeping the fallback in sync avoids a flicker.

What does NOT change

• alter_column and create_foreign_keys stay false — DDL generation is Phase 3.
• Single-key update_record / delete_record on the driver still return a "Phase 1 read-only preview" error; the editing entry points are the composite variants (update_record_composite / delete_record_composite) introduced in [Phase 2] Foreign key composite aggregation (STRING_AGG + FOR XML PATH fallback) #146 / feat(frontend): composite primary key support end-to-end (#148) #222, which handle any arity including length-1 keys. The frontend in feat(frontend): composite primary key support end-to-end (#148) #222 routes through those.
• View create / alter / drop also still return Phase-1 errors; Phase 2 was about row-level CRUD on tables, not view DDL.

Manual QA

Marked done out-of-band against:

• INSERT / UPDATE / DELETE via the UI on a table with single-column PK
• Same on a table with composite PK
• INSERT into an IDENTITY-PK table, with and without supplying the identity value (exercises the SET IDENTITY_INSERT TRY/CATCH wrap from feat(sqlserver): implement insert_record with IDENTITY_INSERT handling (#147) #215)
• TLS off / on / strict against a local SQL Server 2022 container and Azure SQL
• Regression: MySQL / Postgres / SQLite editable flows unchanged (no shared code touched)

Sequencing

This PR is the close-out of Phase 2 and is intentionally last. It depends on:

• [Phase 2] CRUD composite primary keys (trait default methods) #145 — driver scaffold (already in feat/sql-server)
• [Phase 2] Foreign key composite aggregation (STRING_AGG + FOR XML PATH fallback) #146 — composite FK aggregation (already in feat/sql-server)
• [Phase 2] IDENTITY_INSERT handling for inserts on identity tables #147 / PR feat(sqlserver): implement insert_record with IDENTITY_INSERT handling (#147) #215 — insert_record + IDENTITY_INSERT
• [Phase 2] Frontend: DataGrid + Editor + SchemaDiagram composite-PK support #148 / PR feat(frontend): composite primary key support end-to-end (#148) #222 — frontend composite-PK plumbing

Once those are in, this flip is a one-commit close-out and the whole feat/sql-server branch can be squashed onto main.

Test results

cargo test --lib drivers::sqlserver
test result: ok. 119 passed; 0 failed; 0 ignored

ESLint clean on src/hooks/useDrivers.ts.

---

Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com

[kilo-code-bot]

Code Review Summary

Status: 3 Observations | Recommendation: Address observations before merge

Overview

Severity	Count
CRITICAL	0
WARNING	1
SUGGESTION	2

No inline issues were found in the diff itself; all observations relate to unchanged code that becomes problematic once the capability bits are flipped.

Other Observations (not in diff)

Issues found in unchanged code that cannot receive inline comments:

File	Line	Issue
src-tauri/src/drivers/sqlserver/mod.rs	394	WARNING: insert_record still returns a Phase 1 error stub ("SQL Server: INSERT disabled in Phase 1 read-only preview") even though readonly is now false. There is no composite variant for INSERT, so the UI will surface a hard error when users attempt to insert rows. If #215 (which implements INSERT) has not yet landed in feat/sql-server, this PR will break the insert flow.
src-tauri/src/drivers/sqlserver/mod.rs	392	SUGGESTION: Section comment // --- CRUD (disabled by readonly=true in manifest) ----------------------- is stale. readonly is now false; update or remove the parenthetical.
src-tauri/src/drivers/sqlserver/mod.rs	100	SUGGESTION: Comment // inert for now (the readonly flag already hides editing surfaces) is stale because readonly is now false. get_data_types() still returns an empty vec, which may leave the CREATE TABLE / clipboard-import UI with no data type options now that editing surfaces are exposed.

Files Reviewed (2 files)

• src-tauri/src/drivers/sqlserver/mod.rs - capability manifest and test updated; 3 observations in unchanged code
• src/hooks/useDrivers.ts - fallback manifest updated; no issues

Fix these issues in Kilo Cloud

---

_{Reviewed by kimi-k2.6-20260420 · 370,745 tokens}