-
-
Notifications
You must be signed in to change notification settings - Fork 78
Moved and renamed files for consistent C code style #463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Caution Review failedThe pull request is closed. 📝 WalkthroughWalkthroughThis pull request normalizes include paths and filenames to a lowercase 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 16
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
CODING_STYLE_CPP.md (1)
75-79: Fix the enum class example - missing enum name.The example shows
enum class {with an empty name, which is invalid C++ syntax. Add a meaningful enum name for the example.📝 Proposed fix
-enum class { +enum class Status { Ok, NotSupported, Error };
🧹 Nitpick comments (7)
Tactility/Source/app/fileselection/View.cpp (1)
4-12: Same inconsistent include path casing as inTactility/Source/app/files/View.cpp.Line 8 uses lowercase
<tactility/check.h>while surrounding includes (lines 4-7, 9-12) use CamelCase<Tactility/...>. This is the same mixed-casing pattern flagged in the other file.TactilityKernel/Include/tactility/drivers/gpio_controller.h (1)
9-10: Consider using consistent include style.Line 9 uses quotes (
"gpio.h") while line 10 uses angle brackets (<tactility/error.h>). Since both are project headers, consider using a consistent style. Typically, quotes are for relative/local headers and angle brackets for system or installed headers.♻️ Suggested fix for consistency
-#include "gpio.h" -#include <tactility/error.h> +#include <tactility/drivers/gpio.h> +#include <tactility/error.h>CODING_STYLE_C.md (4)
13-16: Useclanguage identifier for C code examples.Since this is a C coding style guide, the code block should use the
clanguage identifier instead ofc++.📝 Suggested fix
-```c++ +```c some_feature.c some_feature.h ```
54-60: Extra space in enum declaration and language identifier.There's a double space before the opening brace, and this C-style enum example uses the
c++identifier.📝 Suggested fixes
-```c++ -enum SomeResult { +```c +enum SomeResult { Ok, NotSupported, Error }; ```
68-72: Useclanguage identifier for C function example.📝 Suggested fix
-```c++ +```c void get_limit() { // ... } ```
94-96: Useclanguage identifier for typedef example.📝 Suggested fix
-```c++ +```c typedef uint32_t thread_id_t; ```TactilityKernel/Source/concurrent/dispatcher.cpp (1)
5-11: Include paths updated correctly.All include directives use the new lowercase
tactility/convention.Minor note: Line 7 uses double quotes (
"tactility/error.h") while other project headers use angle brackets (<tactility/...>). This works but is slightly inconsistent with the surrounding includes.Optional: Align quote style
`#include` <tactility/concurrent/dispatcher.h> -#include "tactility/error.h" +#include <tactility/error.h> `#include` <tactility/concurrent/eventgroup.h>
Summary by CodeRabbit
Documentation
Refactor
✏️ Tip: You can customize this high-level summary in your review settings.