refactor(ui): refactor PanelModal and PanelWidget into MVC Modal, ModalView, and ModalContent classes#1454
Draft
CyanVoxel wants to merge 21 commits into
Draft
refactor(ui): refactor PanelModal and PanelWidget into MVC Modal, ModalView, and ModalContent classes#1454CyanVoxel wants to merge 21 commits into
CyanVoxel wants to merge 21 commits into
Conversation
This reverts commit c8ba9b1.
…alView, and ModalContent classes
CyanVoxel
added
Type: Refactor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Caution
Based on #1451. Blocked until that is pulled and this is rebased.
Summary
This PR refactors the old
PanelModalandPanelWidgets into newModal,ModalView, andModalContentclasses that follow the specific MVC pattern introduced in #1451. Most logic in unchanged, with the biggest changes being the separation of controller and view logic as well as the new (hopefully less ambiguous) names.Tasks Completed