Fix conversion of ONNX Clip nodes when optional inputs are missing. - #80
Open
asnodin wants to merge 2 commits into
Open
Fix conversion of ONNX Clip nodes when optional inputs are missing.#80asnodin wants to merge 2 commits into
asnodin wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ONNX represents omitted optional node inputs as empty strings. These were being converted into PyTorch arguments that yield incorrect output shapes for models containing
Clipnodes without optionalminormax.Added a regression test containing a
Clipnode with an omittedmaxinput (that is now correctly ignored during conversion).