Skip to content

Release 0.109.0#879

Merged
tudddorrr merged 23 commits intomainfrom
develop
Mar 5, 2026
Merged

Release 0.109.0#879
tudddorrr merged 23 commits intomainfrom
develop

Conversation

@tudddorrr
Copy link
Collaborator

No description provided.

tudddorrr and others added 23 commits February 27, 2026 20:14
…ecks

Remove unnecessary checks in middleware
Longer last attempt for Steamworks, return better error code
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Migrate from the scoped alpha packages to the consolidated stable release:
- dinero.js: ^2.0.0-alpha.14 -> ^2.0.0
- @dinero.js/currencies -> dinero.js/currencies (subpath export)
- Remove @dinero.js/currencies as a separate dependency
chore: upgrade dinero.js to v2.0.0 stable
Correctly calculate global value after stat reset
@tudddorrr tudddorrr added the release This pull request contains a release label Mar 5, 2026
@claude
Copy link

claude bot commented Mar 5, 2026

This is a well-structured release with good test coverage throughout. A couple of issues to address:


🟡 Potential Bugs

toggle-archived is not idempotent — creates spurious activity entries

In toggle-archived.ts, the handler unconditionally overwrites deletedAt and creates a game activity, even when the state is not changing:

feedback.deletedAt = archived ? new Date() : null
createGameActivity(em, { type: archived ? GAME_FEEDBACK_ARCHIVED : GAME_FEEDBACK_RESTORED, ... })

Calling with { archived: true } on already-archived feedback will: (1) update deletedAt to a new timestamp, and (2) log a duplicate GAME_FEEDBACK_ARCHIVED activity entry.

Suggested fix:

const currentlyArchived = feedback.deletedAt !== null
if (currentlyArchived === archived) {
  return { status: 200, body: { feedback } }
}

🔵 Minor Issues

Test typo (tests/routes/api/game-stat/put.test.ts):

it('should retry lock tineout exceptions', ...)
//                        ^ "tineout" should be "timeout"

Test Coverage

No issues found — the new toggle-archived and reset-category routes have solid coverage including permission checks, edge cases, and activity log verification.

@tudddorrr tudddorrr merged commit 6b6723b into main Mar 5, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release This pull request contains a release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants