Skip to content

Add empty states for most pages#482

Merged
tudddorrr merged 1 commit intodevelopfrom
empty-states
Mar 1, 2026
Merged

Add empty states for most pages#482
tudddorrr merged 1 commit intodevelopfrom
empty-states

Conversation

@tudddorrr
Copy link
Collaborator

No description provided.

@tudddorrr tudddorrr added the enhancement New feature or request label Mar 1, 2026
@claude
Copy link

claude bot commented Mar 1, 2026

PR #482 Review: Add empty states for most pages

The empty state system is well-structured with good component composition. A couple of things worth addressing:


🔵 Minor — Security: window.open missing noopener/noreferrer

In EmptyState.tsx, both handleLearnMoreClick and handleDocsClick open URLs in a new tab without setting the security options:

// EmptyState.tsx ~line 192, 207
window.open(learnMoreLink, '_blank')
window.open(docs[selectedType], '_blank')

Without noopener,noreferrer, the opened page gets a reference to window.opener, enabling tab-napping. Fix:

window.open(learnMoreLink, '_blank', 'noopener,noreferrer')
window.open(docs[selectedType], '_blank', 'noopener,noreferrer')

🔵 Minor — UI: NoLiveConfig renders buttons before description

NoLiveConfig renders in a different order than all other empty states:

// NoLiveConfig.tsx — current order
<EmptyStateTitle>...</EmptyStateTitle>
<EmptyStateButtons ... />   // ← buttons appear before description
<EmptyStateContent>...</EmptyStateContent>

Every other empty state (via EmptyState) follows: icon → title → content → buttons. This means in the Live Config page, "Learn more" and "Go to docs" appear above the explanatory text, which reads strangely. Swapping EmptyStateButtons and EmptyStateContent would match the established pattern.


No issues found in: Code quality, performance, or the new component architecture overall.

@tudddorrr tudddorrr force-pushed the empty-states branch 3 times, most recently from b3a122a to db6fe60 Compare March 1, 2026 13:48
@tudddorrr tudddorrr merged commit 8128b2a into develop Mar 1, 2026
5 checks passed
@tudddorrr tudddorrr deleted the empty-states branch March 1, 2026 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant