Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9 +/- ##
===========================================
+ Coverage 43.20% 60.86% +17.66%
===========================================
Files 8 8
Lines 250 253 +3
===========================================
+ Hits 108 154 +46
+ Misses 142 99 -43 ☔ View full report in Codecov by Sentry. |
|
Hmm... the Windows error here seems to originate from Pyteomics within ms2ml 🤔 Do we actually care about supporting Windows here? Probably not. |
| The parsed and filtered peptides. | ||
| """ | ||
| peptide_df = pl.read_csv(peptides, separator="\t") | ||
| try: |
There was a problem hiding this comment.
Request: Could we add an error/warning message saying the fallback is occurring?
| peptide_df = pl.read_csv(peptides, separator="\t") | ||
| try: | ||
| peptide_df = pl.read_parquet(peptides) | ||
| except pl.exceptions.ComputeError: |
There was a problem hiding this comment.
R: Can we add a check of the error to make sure the compute error comes from the parsing and not anywhere else?
| import pytest | ||
|
|
||
|
|
||
| @pytest.mark.parametrize("ftype", ["parquet", "csv"]) |
There was a problem hiding this comment.
Note: Since the whole XZ situation ive become a bit more paranoid ... we whould make a PR so the .parquet is generated from a .csv ... just to have no binaries in source control.
2 participants
This PR adds a very small test for sage2lib.