Skip to content

Extract tooltip extensions and add compact scales - #10

Open
tannerlinsley wants to merge 3 commits into
mainfrom
taren/tooltip-bundle-boundaries
Open

Extract tooltip extensions and add compact scales#10
tannerlinsley wants to merge 3 commits into
mainfrom
taren/tooltip-bundle-boundaries

Conversation

@tannerlinsley

Copy link
Copy Markdown
Member

Summary

  • move tooltip rendering and portal transport behind exact opt-in extensions
  • preserve contextual tooltip typing through { use: tooltip, ... }
  • move rich React tooltip bodies to @tanstack/react-charts/tooltip
  • add compact linear, band, point, and ordinal scale entries
  • migrate adapters, examples, benchmarks, and docs

Bundle impact

  • compact React line: 14,225 B gzip (13.89 KiB)
  • tooltip: +3,382 B gzip
  • portal: +806 B gzip

Breaking changes

This 0.x cleanup replaces:

  • tooltip: true with tooltip
  • implicit tooltip option objects with { use: tooltip, ... }
  • portal: true with the imported portal extension
  • React tooltip chart components with imports from @tanstack/react-charts/tooltip

Migration examples are in CHANGELOG.md. Deferred bundle options are recorded in PLAN.md.

Validation

  • pnpm typecheck
  • pnpm test
  • pnpm docs:check
  • pnpm bundle:check
  • pnpm package:check
  • pnpm release:artifacts
  • pnpm release:check
  • pnpm canvas:check

@coderabbitai

coderabbitai Bot commented Jul 31, 2026

Copy link
Copy Markdown

Important

Review skipped

Too many files!

This PR contains 147 files, which is 47 over the limit of 100.

To get a review, narrow the scope:
• coderabbit review --committed # exclude uncommitted changes
• coderabbit review --dir # limit to a subdirectory
• coderabbit review --base # compare against a closer base

Upgrade to a paid plan to raise the limit.

This review couldn't start because sufficient usage credits or metered capacity aren't available. Add credits or update usage-based reviews in the billing tab, then retry.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: b56b2b74-6700-4af5-8550-548c2db97bcd

📥 Commits

Reviewing files that changed from the base of the PR and between fa9a61b and 6764c3e.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (147)
  • API-FRICTION.md
  • CHANGELOG.md
  • PLAN.md
  • README.md
  • benchmarks/bundle-size/README.md
  • benchmarks/bundle-size/universal-baseline.json
  • benchmarks/comparison/bundle-baseline.json
  • benchmarks/comparison/libraries/tanstack/base.ts
  • benchmarks/conformance/cases/34-pointer-tooltip/tanstack.ts
  • benchmarks/conformance/cases/35-grouped-tooltip/tanstack.ts
  • benchmarks/conformance/cases/65-voronoi-nearest-tooltip/tanstack.ts
  • benchmarks/conformance/cases/85-scrollable-resource-lanes/tanstack.ts
  • benchmarks/conformance/cases/86-streaming-window-preservation/tanstack.ts
  • benchmarks/conformance/shared/mount.ts
  • benchmarks/entries/charts-compact-linear-scene.ts
  • benchmarks/entries/charts-react-compact-line-tooltip-portal.ts
  • benchmarks/entries/charts-react-compact-line-tooltip.ts
  • benchmarks/entries/charts-react-compact-line.ts
  • benchmarks/entries/charts-react-stats-parity.tsx
  • benchmarks/entries/charts-scale-band-kernel.ts
  • benchmarks/entries/charts-scale-family-kernel.ts
  • benchmarks/entries/charts-scale-linear-kernel.ts
  • benchmarks/entries/charts-scale-ordinal-kernel.ts
  • benchmarks/entries/charts-scale-point-kernel.ts
  • benchmarks/entries/charts-stats-parity.ts
  • benchmarks/entries/charts-tooltip-kernel.ts
  • benchmarks/entries/charts-tooltip-portal-kernel.ts
  • docs/comparison.md
  • docs/concepts/chart-definitions.md
  • docs/concepts/scales-and-d3.md
  • docs/examples/interactive-charts.md
  • docs/framework/angular/adapter.md
  • docs/framework/lit/adapter.md
  • docs/framework/octane/quick-start.md
  • docs/framework/preact/adapter.md
  • docs/framework/react/adapter.md
  • docs/framework/react/quick-start.md
  • docs/framework/react/reference/chart.md
  • docs/framework/solid/adapter.md
  • docs/framework/svelte/adapter.md
  • docs/framework/vue/adapter.md
  • docs/guides/bundle-size-and-performance.md
  • docs/guides/themes-and-styling.md
  • docs/guides/tooltips-and-focus.md
  • docs/installation.md
  • docs/overview.md
  • docs/quick-start.md
  • docs/reference/chart-definitions.md
  • docs/reference/dom-host.md
  • docs/reference/focus-and-interaction.md
  • docs/reference/rendering-and-export.md
  • docs/reference/scales-guides-and-color.md
  • docs/reference/types.md
  • examples/charts-octane/src/App.tsrx
  • examples/charts-react/src/App.tsx
  • examples/sandbox/src/App.tsx
  • llms.txt
  • package.json
  • packages/alpine-charts/src/index.test.ts
  • packages/angular-charts/README.md
  • packages/angular-charts/src/Chart.test.ts
  • packages/charts-core/README.md
  • packages/charts-core/docs/comparison.md
  • packages/charts-core/docs/concepts/chart-definitions.md
  • packages/charts-core/docs/concepts/scales-and-d3.md
  • packages/charts-core/docs/examples/interactive-charts.md
  • packages/charts-core/docs/framework/angular/adapter.md
  • packages/charts-core/docs/framework/lit/adapter.md
  • packages/charts-core/docs/framework/octane/quick-start.md
  • packages/charts-core/docs/framework/preact/adapter.md
  • packages/charts-core/docs/framework/react/adapter.md
  • packages/charts-core/docs/framework/react/quick-start.md
  • packages/charts-core/docs/framework/react/reference/chart.md
  • packages/charts-core/docs/framework/solid/adapter.md
  • packages/charts-core/docs/framework/svelte/adapter.md
  • packages/charts-core/docs/framework/vue/adapter.md
  • packages/charts-core/docs/guides/bundle-size-and-performance.md
  • packages/charts-core/docs/guides/themes-and-styling.md
  • packages/charts-core/docs/guides/tooltips-and-focus.md
  • packages/charts-core/docs/installation.md
  • packages/charts-core/docs/overview.md
  • packages/charts-core/docs/quick-start.md
  • packages/charts-core/docs/reference/chart-definitions.md
  • packages/charts-core/docs/reference/dom-host.md
  • packages/charts-core/docs/reference/focus-and-interaction.md
  • packages/charts-core/docs/reference/rendering-and-export.md
  • packages/charts-core/docs/reference/scales-guides-and-color.md
  • packages/charts-core/docs/reference/types.md
  • packages/charts-core/llms.txt
  • packages/charts-core/package.json
  • packages/charts-core/src/canvas.test.ts
  • packages/charts-core/src/color-scale.test.ts
  • packages/charts-core/src/exports.test.ts
  • packages/charts-core/src/index.ts
  • packages/charts-core/src/mark.ts
  • packages/charts-core/src/renderer.test.ts
  • packages/charts-core/src/renderer.ts
  • packages/charts-core/src/runtime.test.ts
  • packages/charts-core/src/scales.ts
  • packages/charts-core/src/tooltip-portal.ts
  • packages/charts-core/src/tooltip-position.ts
  • packages/charts-core/src/tooltip.ts
  • packages/charts-core/src/type-contract.test.ts
  • packages/charts-core/src/types.ts
  • packages/charts-scales/LICENSE
  • packages/charts-scales/README.md
  • packages/charts-scales/package.json
  • packages/charts-scales/src/band-kernel.ts
  • packages/charts-scales/src/band.ts
  • packages/charts-scales/src/categorical.test.ts
  • packages/charts-scales/src/exports.test.ts
  • packages/charts-scales/src/intern.ts
  • packages/charts-scales/src/linear.test.ts
  • packages/charts-scales/src/linear.ts
  • packages/charts-scales/src/ordinal.ts
  • packages/charts-scales/src/point.ts
  • packages/lit-charts/README.md
  • packages/lit-charts/src/Chart.test.ts
  • packages/octane-charts/README.md
  • packages/octane-charts/src/CanvasChart.client.test.tsrx
  • packages/octane-charts/src/Chart.client.test.tsrx
  • packages/preact-charts/README.md
  • packages/preact-charts/src/Chart.test.tsx
  • packages/react-charts/README.md
  • packages/react-charts/package.json
  • packages/react-charts/src/CanvasChart.test.tsx
  • packages/react-charts/src/CanvasChart.tsx
  • packages/react-charts/src/Chart.test.tsx
  • packages/react-charts/src/Chart.tsx
  • packages/react-charts/src/RendererChart.tsx
  • packages/react-charts/src/canvas.ts
  • packages/react-charts/src/core.ts
  • packages/react-charts/src/index.ts
  • packages/react-charts/src/tooltip.tsx
  • packages/solid-charts/README.md
  • packages/solid-charts/src/Chart.test.tsx
  • packages/svelte-charts/README.md
  • packages/svelte-charts/tests/Chart.test.ts
  • packages/vue-charts/README.md
  • packages/vue-charts/src/Chart.test.ts
  • scripts/check-canvas-renderer.mjs
  • scripts/check-packed-consumers.mjs
  • scripts/docs-contract.mjs
  • scripts/measure-bundles.mjs
  • scripts/release-artifacts.mjs
  • scripts/release-package-config.mjs
  • scripts/sync-package-docs.mjs

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant