Add environment-safe chart barrels - #8
Open
tannerlinsley wants to merge 1 commit into
Open
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (23)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughThe package adds ChangesPortable package boundaries
Estimated code review effort: 4 (Complex) | ~45 minutes Sequence Diagram(s)sequenceDiagram
participant PortableConsumer
participant PortableEntry
participant PackedConsumerChecks
PortableConsumer->>PortableEntry: Import portable runtime and types
PackedConsumerChecks->>PortableEntry: Resolve packed declarations and bundle entry
PackedConsumerChecks->>PackedConsumerChecks: Reject browser-host modules in portable output
Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@tanstack/charts/portablefor common authoring, runtime, scene, and static SVG values without browser hosts or adapters@tanstack/charts/typesfor portable public contractsCompatibility
The existing
@tanstack/chartsruntime and type API is unchanged. Both new subpaths are additive, and no platform-specific export conditions are introduced.The packed portable barrel is 55.26 kB minified / 17.04 kB gzip. Granular subpaths remain available for bundle-sensitive consumers.
Validation
tsc --noEmit -p tsconfig.jsonvitest run— 464 files, 3,002 testsnode scripts/check-packed-consumers.mjsnode scripts/check-framework-adapters.mjs— 7 adaptersnode scripts/check-docs.mjsgit diff --checkSummary by CodeRabbit
New Features
Documentation
Bug Fixes