fix: resolve Electron e2e test timeout failures in CI#1393
Merged
Conversation
More templates
@tanstack/angular-db
@tanstack/db
@tanstack/db-browser-wa-sqlite-persisted-collection
@tanstack/db-cloudflare-do-sqlite-persisted-collection
@tanstack/db-electron-sqlite-persisted-collection
@tanstack/db-expo-sqlite-persisted-collection
@tanstack/db-ivm
@tanstack/db-node-sqlite-persisted-collection
@tanstack/db-react-native-sqlite-persisted-collection
@tanstack/db-sqlite-persisted-collection-core
@tanstack/electric-db-collection
@tanstack/offline-transactions
@tanstack/powersync-db-collection
@tanstack/query-db-collection
@tanstack/react-db
@tanstack/rxdb-db-collection
@tanstack/solid-db
@tanstack/svelte-db
@tanstack/trailbase-db-collection
@tanstack/vue-db
commit: |
Contributor
|
Size Change: 0 B Total Size: 110 kB ℹ️ View Unchanged
|
Contributor
|
Size Change: 0 B Total Size: 4.23 kB ℹ️ View Unchanged
|
The Electron persisted collection conformance suite (113 tests) was failing in CI because TANSTACK_DB_ELECTRON_E2E_ALL=1 caused every IPC call to spawn a separate Electron process (~2-3s each). All 6 collections shared a single serialized invoke queue, so background getStreamPosition calls queued up and exceeded the 5000ms per-request timeout before being dequeued. - Remove TANSTACK_DB_ELECTRON_E2E_ALL=1 from CI workflow. The runtime bridge e2e test (3 tests) already validates real Electron IPC independently — it always spawns real processes regardless of the env var. The conformance suite validates persistence adapter correctness, which the fast in-process mode covers fully. - Increase timeoutMs to 90s in full e2e mode as a safety net for local test:e2e:all usage. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
9a52753 to
707190e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
beforeAlltimed out —getStreamPositionIPC calls exceeded the 5000ms timeout while waiting in a shared serialized queueTANSTACK_DB_ELECTRON_E2E_ALL=1from CI since the runtime bridge e2e test (3 tests) already validates real Electron IPC independentlytimeoutMsto 90s in full e2e mode as a safety net for localtest:e2e:allusageTest plan
TANSTACK_DB_ELECTRON_E2E_ALL=1— all 113 tests skipped🤖 Generated with Claude Code