Skip to content

Update README#1734

Merged
LeCarbonator merged 5 commits into
TanStack:mainfrom
LadyBluenotes:fix-readme
Sep 19, 2025
Merged

Update README#1734
LeCarbonator merged 5 commits into
TanStack:mainfrom
LadyBluenotes:fix-readme

Conversation

@LadyBluenotes
Copy link
Copy Markdown
Member

  • Updating README so it's more consistent across TanStack Libraries
  • Added CTA/ sponsors
  • Added ecosystem links

Copy link
Copy Markdown
Contributor

@LeCarbonator LeCarbonator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it a lot! It's definitely more organized now. There's something worth pointing out regarding visuals, but it's not a big deal in my opinion.

Thanks for the rewrite!

Comment thread README.md
Copy link
Copy Markdown
Contributor

@LeCarbonator LeCarbonator Sep 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logos of partners are hard to read with dark mode. This also seems to happen with other packages like TanStack Router. Do you think it's fine?

image

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I'm not quite sure how to solve this, I noticed it during the previews. I might have to see what people suggest.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good.

The router preview for reference:

image

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd assume the best option is to add a white background to them??? At the moment, I'm pulling most of the logos from the tanstack site / whatever was pre-existing.

Mostly didn't want to add a bunch of images to the media folders of all repos, but that may be the only option

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably. Either way, it's not blocking this PR, so I'll merge it

@LeCarbonator LeCarbonator merged commit 6892ed0 into TanStack:main Sep 19, 2025
1 check passed
@LadyBluenotes LadyBluenotes deleted the fix-readme branch September 19, 2025 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants