-
-
Notifications
You must be signed in to change notification settings - Fork 580
fix(form-core): Validate fields without instances #2001
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: e710f91 The changes in this PR will be included in the next version bump. This PR includes changesets to release 13 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
View your CI Pipeline Execution ↗ for commit e710f91
☁️ Nx Cloud last updated this comment at |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2001 +/- ##
==========================================
- Coverage 90.35% 89.48% -0.87%
==========================================
Files 38 48 +10
Lines 1752 1950 +198
Branches 444 491 +47
==========================================
+ Hits 1583 1745 +162
- Misses 149 184 +35
- Partials 20 21 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
🎯 Changes
Fixes: #1865
So far, in case when there was no field instance - validation was not run for a given field.
Explicit call to form validation will not be expensive, so it will be better to have this as fallback than nothing at all.
✅ Checklist
pnpm test:pr.🚀 Release Impact