test(solid-query/useQueries): add test for not fetching during the restoring period when 'isRestoring' is true by sukvvon · Pull Request #10951 · TanStack/query

sukvvon · 2026-06-14T19:30:41Z

🎯 Changes

react-query's useQueries tests cover that queries do not fetch while isRestoring is true, but solid-query had no equivalent. This ports that coverage.

Add a test that wraps useQueries in an IsRestoringProvider set to true and asserts that both queries stay pending / idle with no data and that their queryFns are never called, even after advancing past their sleep duration.

The test passes against the current behavior — no source changes.

✅ Checklist

I have followed the steps in the Contributing guide.
I have tested this code locally with pnpm run test:pr.

🚀 Release Impact

This change affects published code, and I have generated a changeset.
This change is docs/CI/dev-only (no release).

Summary by CodeRabbit

Tests
- Expanded test coverage for query restoration scenarios, ensuring queries properly maintain pending status with idle fetch status when restoring application state, preventing unnecessary query function invocation during restoration, and validating that state remains stable and unchanged throughout the restoration process and subsequent operations.

…storing period when 'isRestoring' is true

coderabbitai · 2026-06-14T19:30:55Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: e3c0117a-acdb-4ed4-8d14-d8ccbf314b6c

📥 Commits

Reviewing files that changed from the base of the PR and between 0e2bfe7 and 9f6bb17.

📒 Files selected for processing (1)

packages/solid-query/src/__tests__/useQueries.test.tsx

📝 Walkthrough

Walkthrough

Adds IsRestoringProvider to the solid-query useQueries test file imports and introduces one new test that wraps two useQueries calls inside IsRestoringProvider (returning true), asserting both queries remain in pending/idle state and their query functions are never invoked.

useQueries isRestoring test

Layer / File(s)	Summary
`IsRestoringProvider` import and restoring test case `packages/solid-query/src/__tests__/useQueries.test.tsx`	`IsRestoringProvider` is added to the `..` import block; a new test renders `useQueries` under `IsRestoringProvider` with `true`, asserts `status: pending` and `fetchStatus: idle` for both queries initially and after timer advancement, and verifies query functions have zero call counts.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5 minutes

Poem

🐇 A restoring flag holds the queries at bay,
No fetches shall run on this fine idle day.
Pending and quiet, the statuses rest,
Zero calls made — the bunny says "best!"
Timer advanced, still nothing has stirred,
The restore gate works — every check has been heard. 🌿

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main change: adding a test for useQueries that verifies queries do not fetch when isRestoring is true.
Description check	✅ Passed	The description follows the template structure with Changes section, completed Checklist, and Release Impact. All required sections are present and properly filled out.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch test/solid-query-useQueries-isRestoring

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

nx-cloud · 2026-06-14T19:31:07Z

View your CI Pipeline Execution ↗ for commit 9f6bb17

Command	Status	Duration	Result
`nx affected --targets=test:sherif,test:knip,tes...`	✅ Succeeded	4m 36s	View ↗
`nx run-many --target=build --exclude=examples/*...`	✅ Succeeded	10s	View ↗

☁️ Nx Cloud last updated this comment at 2026-06-14 19:36:07 UTC

github-actions · 2026-06-14T19:31:23Z

🚀 Changeset Version Preview

No changeset entries found. Merging this PR will not cause a version bump for any packages.

pkg-pr-new · 2026-06-14T19:34:02Z

More templates

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@10951

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@10951

@tanstack/lit-query

npm i https://pkg.pr.new/@tanstack/lit-query@10951

@tanstack/preact-query

npm i https://pkg.pr.new/@tanstack/preact-query@10951

@tanstack/preact-query-devtools

npm i https://pkg.pr.new/@tanstack/preact-query-devtools@10951

@tanstack/preact-query-persist-client

npm i https://pkg.pr.new/@tanstack/preact-query-persist-client@10951

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@10951

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@10951

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@10951

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@10951

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@10951

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@10951

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@10951

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@10951

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@10951

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@10951

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@10951

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@10951

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@10951

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@10951

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@10951

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@10951

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@10951

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@10951

commit: 9f6bb17

github-actions · 2026-06-14T19:34:27Z

size-limit report 📦

Path	Size
react full	12.11 KB (0%)
react minimal	9.08 KB (0%)

test(solid-query/useQueries): add test for not fetching during the re…

9f6bb17

…storing period when 'isRestoring' is true

sukvvon self-assigned this Jun 14, 2026

sukvvon merged commit 588b30f into main Jun 14, 2026
9 checks passed

sukvvon deleted the test/solid-query-useQueries-isRestoring branch June 14, 2026 19:36

coderabbitai Bot mentioned this pull request Jun 14, 2026

test(solid-query/useQueries): add test for using a provided custom 'queryClient' #10952

Merged

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

test(solid-query/useQueries): add test for not fetching during the restoring period when 'isRestoring' is true#10951

test(solid-query/useQueries): add test for not fetching during the restoring period when 'isRestoring' is true#10951
sukvvon merged 1 commit into
mainfrom
test/solid-query-useQueries-isRestoring

sukvvon commented Jun 14, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Jun 14, 2026 •

edited

Loading

Walkthrough

Estimated code review effort

Poem

❌ Failed checks (1 warning)

Uh oh!

nx-cloud Bot commented Jun 14, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Jun 14, 2026

Uh oh!

pkg-pr-new Bot commented Jun 14, 2026

Uh oh!

github-actions Bot commented Jun 14, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

sukvvon commented Jun 14, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎯 Changes

✅ Checklist

🚀 Release Impact

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Jun 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Estimated code review effort

Poem

❌ Failed checks (1 warning)

Uh oh!

nx-cloud Bot commented Jun 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jun 14, 2026

🚀 Changeset Version Preview

Uh oh!

pkg-pr-new Bot commented Jun 14, 2026

Uh oh!

github-actions Bot commented Jun 14, 2026

size-limit report 📦

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

sukvvon commented Jun 14, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Jun 14, 2026 •

edited

Loading

nx-cloud Bot commented Jun 14, 2026 •

edited

Loading