bench(memory): add settle macro/micro-tasks after each loop to reduce peak memory allocation (hopefully)#7632
bench(memory): add settle macro/micro-tasks after each loop to reduce peak memory allocation (hopefully)#7632Sheraff wants to merge 1 commit into
Conversation
… peak memory allocation (hopefully)
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (9)
📝 WalkthroughWalkthroughTwo new async settling helpers are introduced for memory benchmarks: ChangesBenchmark Settle Helpers
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
|
View your CI Pipeline Execution ↗ for commit eef37f2
☁️ Nx Cloud last updated this comment at |
🚀 Changeset Version Preview3 package(s) bumped directly, 10 bumped as dependents. 🟩 Patch bumps
|
Bundle Size Benchmarks
Current gzip tracks all emitted client JS chunks. Initial gzip tracks only the entry/import graph. Trend sparkline is historical current gzip ending with this PR measurement; lower is better. |
Merging this PR will degrade performance by 3.11%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | Memory | mem mount-unmount (solid) |
492.9 KB | 1,146.1 KB | -57% |
| ❌ | Memory | mem aborted-requests (react) |
1.1 MB | 2.2 MB | -50.61% |
| ❌ | Memory | mem unique-location-churn (solid) |
842.4 KB | 1,435.8 KB | -41.33% |
| ❌ | Memory | mem interrupted-navigations (solid) |
845.1 KB | 1,437.4 KB | -41.21% |
| ❌ | Memory | mem peak-large-page (react) |
2 MB | 3.1 MB | -35.23% |
| ❌ | Memory | mem loader-data-retention (solid) |
158.5 KB | 229.5 KB | -30.94% |
| ❌ | Memory | mem error-paths redirect (react) |
469.9 KB | 667.9 KB | -29.65% |
| ❌ | Memory | mem peak-large-page (vue) |
2.2 MB | 2.9 MB | -23.2% |
| ❌ | Memory | mem preload-churn (solid) |
580.3 KB | 704.7 KB | -17.65% |
| ❌ | Memory | mem request-churn (solid) |
1.1 MB | 1.3 MB | -15.18% |
| ❌ | Memory | mem loader-data-retention (react) |
203.4 KB | 223 KB | -8.79% |
| ❌ | Simulation | ssr dehydrate plain control (vue) |
145 ms | 151.3 ms | -4.15% |
| ❌ | Memory | mem aborted-requests (vue) |
982.4 KB | 1,014.4 KB | -3.15% |
| ⚡ | Memory | mem serialization-payload (react) |
35 MB | 6.4 MB | ×5.5 |
| ⚡ | Memory | mem error-paths unmatched (react) |
1,120.8 KB | 517.9 KB | ×2.2 |
| ⚡ | Memory | mem navigation-churn (vue) |
992.1 KB | 553.3 KB | +79.3% |
| ⚡ | Memory | mem aborted-requests (solid) |
2.7 MB | 2.3 MB | +21.05% |
| ⚡ | Memory | mem error-paths error (react) |
815.4 KB | 678.4 KB | +20.2% |
| ⚡ | Memory | mem unique-location-churn (vue) |
1,156.7 KB | 1,005.4 KB | +15.05% |
| ⚡ | Memory | mem error-paths not-found (react) |
941.6 KB | 851.3 KB | +10.61% |
| ... | ... | ... | ... | ... | ... |
ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing bench-memory-rest-to-reduce-peaks-maybe (eef37f2) with main (a415471)
Summary by CodeRabbit
Tests
Chores