Skip to content

fix(start-server-core): return 406 instead of 500 for non-HTML Accept headers #7925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
okxint wants to merge 2 commits into
base: main
Choose a base branch
from
+3 −3
Open

fix(start-server-core): return 406 instead of 500 for non-HTML Accept headers #7925

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
522a4f3
fix(router-plugin): escape single quotes in split route file paths
okxint Jul 24, 2026
7a75acf
fix(start-server-core): return 406 instead of 500 for non-HTML Accept…
okxint Jul 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/router-plugin/src/core/code-splitter/compilers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -623,7 +623,7 @@ export function compileCodeSplitReferenceRoute(
) {
programPath.unshiftContainer('body', [
template.statement(
`const ${splitNodeMeta.localImporterIdent} = () => import('${splitUrl}')`,

@schiller-manuel schiller-manuel Jul 30, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this file should not be changed in this PR

`const ${splitNodeMeta.localImporterIdent} = () => import('${splitUrl.replace(/'/g, "\\'")}')`,
)(),
])
}
Expand Down Expand Up @@ -719,7 +719,7 @@ export function compileCodeSplitReferenceRoute(
) {
programPath.unshiftContainer('body', [
template.statement(
`const ${splitNodeMeta.localImporterIdent} = () => import('${splitUrl}')`,
`const ${splitNodeMeta.localImporterIdent} = () => import('${splitUrl.replace(/'/g, "\\'")}')`,
)(),
])
}
Expand Down
2 changes: 1 addition & 1 deletion packages/start-server-core/src/createStartHandler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -557,7 +557,7 @@ export function createStartHandler<TRegister = Register>(
return normalizeSsrResponse(
Response.json(
{ error: 'Only HTML requests are supported here' },
{ status: 500 },

@schiller-manuel schiller-manuel Jul 30, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should add an e2e test

{ status: 406 },
),
)
}
Expand Down