fix(table-core): Do not select subrows if enableSubRowSelection is set to false - #5274
Closed
jpedroh wants to merge 3 commits into
Closed
fix(table-core): Do not select subrows if enableSubRowSelection is set to false#5274jpedroh wants to merge 3 commits into
jpedroh wants to merge 3 commits into
Conversation
jpedroh
marked this pull request as draft
January 14, 2024 14:51
jpedroh
marked this pull request as ready for review
January 14, 2024 15:31
Member
|
closing in favor of #6495 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5116.
There are two cases here that were not being covered by the current code:
enableSubRowSelectionis a boolean and is set to true, then only the first level of rows should be selected. We can easily achieve this by iterating overrowsinstead offlatRows.enableSubRowSelectionis a function. In this scenario we must run the check recursively for all subrows. The easiest way I've found to solve this was to just iterate over rows using themutateRowIsSelectedhelper function.In order to not losing the performance improvement that was already implemented, I've kept the old flow and just in case enableRowSeleciton is a function, we will reach the slower path (which might not be very common anyway)