Prevents deletion of non-selectable rows when calling onRowSelectionChange - #5996
Closed
simon-curtis wants to merge 2 commits into
Closed
Prevents deletion of non-selectable rows when calling onRowSelectionChange#5996simon-curtis wants to merge 2 commits into
onRowSelectionChange#5996simon-curtis wants to merge 2 commits into
Conversation
Member
|
closing in favor of #6495 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This simple fix prevents deleting non-selectable rows from the RowSelectionState if the row is not selectable.
In my case I need to show to the user that an item has been added to the list previously and cannot be un-checked via this menu, leaving it in a checked and disabled state.
Unchecking the header checkbox currently removes the checked state, but it should not.